Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lumpy performance of Schema.org site #1171

Closed
RichardWallis opened this issue May 20, 2016 · 1 comment
Closed

Lumpy performance of Schema.org site #1171

RichardWallis opened this issue May 20, 2016 · 1 comment

Comments

@RichardWallis
Copy link
Contributor

Issue seems to be around new instances spawned to handle load having to create their own in memory page cache. If you are unfortunate enough to get a new instance to service your request you have to wait whist it builds and caches pages to answer you.

Suggested investigation of use of NDB Cloud Datastore to create a single page cache to be shared by all instances.
This was referenced May 20, 2016
Closed
Merged
danbri added a commit that referenced this issue Jun 17, 2016
@danbri
Merge pull request #1213 from schemaorg/ndbpagestore
9f2c02d 
Ndbpagestore into Makemake

Copying notes from #1173 
In response to issue (#1171) 
Overview:

Previously created pages are held in a within instance memory cache that is shared between threads. This means that each page is recreated for each application instance. We previously noted that the live site spawned off dozens of instances to support the load,
This version uses the Cloud Datastore to hold cached pages.
The single NDB store is shared between all threads of all instances.
​Should​ result in a lot less page creations, and more importantly you having to wait for a new instance to create you a page.
The NDB store is persistent so will keep the page store even when you reload/deploy a new version of the code/data.
Implemented code that detects this condition and deletes all pages in the store as it starts.
For early supporting there is a way to manually call this caheFlush function.
@danbri danbri mentioned this issue Jun 17, 2016
Merged
@RichardWallis
Copy link
Contributor Author

Fixed in 3.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@RichardWallis