deliveryLeadTime description update #1201

Closed
gmackenz opened this Issue Jun 10, 2016 · 6 comments

Projects

None yet

3 participants

@gmackenz
Contributor

On site pickup is a delivery option. To make deliveryLeadTime clearer, modify the description to read:

"The typical delay between the receipt of the order and the goods either leaving the warehouse or being prepared for pickup, in case the delivery method is on site pickup."
#1200

@danbri
Contributor
danbri commented Jun 13, 2016

That seems a sensible improvement to "The typical delay between the receipt of the order and the goods leaving the warehouse."

@mfhepp
Contributor
mfhepp commented Jun 14, 2016

Yes, makes sense.
+1

@danbri
Contributor
danbri commented Aug 1, 2016

@gmackenz since the PR got a bit tangled, could you simply copy/paste the essence of your proposal, or is it simple:

  • ... that we change deliveryLeadTime to say "The typical delay between the receipt of the order and the goods either leaving the warehouse or being prepared for pickup, in case the delivery method is on site pickup." instead of "The typical delay between the receipt of the order and the goods leaving the warehouse." ?
@gmackenz
Contributor
gmackenz commented Aug 1, 2016

@danbri - That's the proposed change, would be great to add it to sdo-makemake

@danbri danbri pushed a commit that closed this issue Aug 1, 2016
Dan Brickley Last minute but very harmless looking improvement to /deliveryLeadTime
Fixes #1201
changed deliveryLeadTime to say "The typical delay between the receipt of the order and the goods either leaving the warehouse or being prepared for pickup, in case the delivery method is on site pickup." instead of "The typical delay between the receipt of the order and the goods leaving the warehouse."
78abeb4
@danbri danbri closed this in 78abeb4 Aug 1, 2016
@danbri
Contributor
danbri commented Aug 1, 2016

@gmackenz thanks. It seems entirely innocuous, I'm going to just do it. [...] I just did it.

@gmackenz
Contributor
gmackenz commented Aug 1, 2016

I saw what you did there :)

Gordon Mackenzie | Schema Wrangler (Ontologist) | gmackenz@google.com |

On Mon, Aug 1, 2016 at 1:19 PM, Dan Brickley notifications@github.com
wrote:

@gmackenz https://github.com/gmackenz thanks. It seems entirely
innocuous, I'm going to just do it. [...] I just did it.

โ€”
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#1201 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AEeZItPWuNlkOnieIRzh4PAMOf6RFiJzks5qblTkgaJpZM4IzMhw
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment