Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meta-issue for sdo-makemake release (likely as version 3.1) #1212

Closed
danbri opened this issue Jun 17, 2016 · 28 comments
Closed

Meta-issue for sdo-makemake release (likely as version 3.1) #1212

danbri opened this issue Jun 17, 2016 · 28 comments

Comments

@danbri
Copy link
Contributor

@danbri danbri commented Jun 17, 2016

This issue tracks release planning for schema.org's release codenamed sdo-makemake.

The release is codenamed after the dwarf planet Makemake, and because our focus for this release is primarily fixups:

  • The priority for the release is to correct some unintended reversions (#1203) that were included in 3.0 during the major changes that moved medical terminology into the health-lifesci extension.
  • Secondary priority is to get us back on a faster release cycle.
  • Include "low hanging fruit" vocabulary improvements but publish ASAP rather than wait for more complex designs (e.g. hotels) to complete. We should always be ready to release a new version with low administrative cost; "waiting for x to be completed" is an unfortunate pattern to slip into.
  • update July 26: we will include hotels too.
@danbri
Copy link
Contributor Author

@danbri danbri commented Jul 26, 2016

See http://webschemas.org/docs/releases.html for some more stuff that's in there. We are close to wrapping up hotels, and there is also some modest but useful polish around dataset description.

@danbri
Copy link
Contributor Author

@danbri danbri commented Jul 29, 2016

@danbri
Copy link
Contributor Author

@danbri danbri commented Jul 29, 2016

Feedback received elsewhere in review (I'll edit this post)

  • From @vholland w.r.t. amenityFeature, "can we change the domain to LocalBusiness (instead of the more specific LodgingBusiness)?".
    • @danbri suggests "Place" is a better fit, some amenities are likely to be nearby-ness of a relevant local business, but there are other kinds of non-business amenity. Glancing over http://wiki.openstreetmap.org/wiki/Key:amenity e.g. see "drinking water", "ice cream"(parlour/shop nearby), nearby "college", "bicycle_parking", "grit bin", "fuel"(station), "parking" etc., ... lots are local business-like in their own right but would be amenity features of an enclosing or nearby Place.
      • done
  • @vholland also notes "It appears the update omitted http://schema.org/Residence and its subtypes" in that same post. @gmackenz opened a dedicated issue as this is relatively complex: #1270
  • Hans Polak noticed that BedDetails didn't have a supertype; @RichardWallis + @danbri fixed this immediately (as Intangible, @mfhepp will double-check the intention but thinks this is likely correct)
  • @gmackenz noticed "Example 2 on starRating be updated to use author instead of name for DEHOGA?"
    • done (also in docs/hotels.html)
  • I've just merged the tiny example markup fix for #1260 - needs adding to /docs/releases.html

Added extra:

  • @danbri proposes (aug 1st, after @chaals and @mfhepp 's ok's, although @mfhepp signed off in #1201 for this) we also squeeze in a quick fix for #1201 since it is just a sensible wording change. However people have already been reviewing the release candidate, so if anyone is uncomfortable with last minute changes like this please say. See #1201 for specific wording.
@chaals
Copy link
Contributor

@chaals chaals commented Jul 30, 2016

Looks good to me.

@mfhepp
Copy link
Contributor

@mfhepp mfhepp commented Jul 30, 2016

Looks good to me, too.


martin hepp http://www.heppnetz.de
mhepp@computer.org @mfhepp

On 30 Jul 2016, at 22:07, chaals notifications@github.com wrote:

Looks good to me.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

@danbri
Copy link
Contributor Author

@danbri danbri commented Jul 30, 2016

@danbri danbri self-assigned this Jul 31, 2016
danbri added a commit that referenced this issue Aug 2, 2016
…mer.

@rvguha in reviewing the release noted that these may seem esoteric issues to a large section of
schema.org's audience, so I have tried to make clearer who the intended audience is.
For v3.1 release, tracked in #1212
@danbri
Copy link
Contributor Author

@danbri danbri commented Aug 3, 2016

Relaying from @scor in 1:1 mail , "looks good!"

Message-ID: CAGR+nnGFMEJ2FREjM0jn6vdn+auCM4Ye1unq_ptR6Kiz8BSbRA@mail.gmail.com
Subject: Re: Schema.org v3.1 release candidate (sdo-makemake branch) - please
review for release in 1-2 weeks
To: Dan Brickley danbri@google.com
looks good! thanks for pinging me!

...and I heard from @shankarnat who is aiming to complete his review today (Aug 3rd).

@danbri
Copy link
Contributor Author

@danbri danbri commented Aug 5, 2016

@shankarnat shankarnat closed this Aug 5, 2016
@shankarnat
Copy link
Collaborator

@shankarnat shankarnat commented Aug 5, 2016

Thanks Dan for Pinging me, looks good to me.

@shankarnat shankarnat reopened this Aug 5, 2016
@danbri
Copy link
Contributor Author

@danbri danbri commented Aug 5, 2016

Ok, all reviews are in. Thanks everyone! There are some modest todos listed above, and I'll make a final round of technical checks with @RichardWallis to try to avoid a repeat of the problems we had last time. Aiming for publication early next week! Thanks again :)

@danbri
Copy link
Contributor Author

@danbri danbri commented Aug 5, 2016

I believe all the little fixes listed above are now correctly implemented. I'm sketching this for a release next week on Tuesday 9th August.

danbri added a commit that referenced this issue Aug 8, 2016
via: curl http://localhost:8080/version/build-latest > schema-all.html

Generated per RELEASING.TXT tweaking XX, and 'localhost' mentions.

Note that MedicalBusiness leaked into the file somehow, I have commented it out manually.

/cc #1212
danbri added a commit that referenced this issue Aug 8, 2016
@danbri
Copy link
Contributor Author

@danbri danbri commented Aug 8, 2016

Ok I have published tomorrow's release to http://schema.org/

Technically we are a few hours early, but it gives us time to verify that everything is functioning properly.

Thanks everyone!

@twamarc
Copy link
Contributor

@twamarc twamarc commented Aug 8, 2016

A possible bug on home page text of health-lifesci extension: http://health-lifesci.schema.org/:
It's just the text I think. Is it the same at your side or it's on my local machine?

`The schema.org '�klzzwxh:0004'� was �klzzwxh:0005� in collaboration with �klzzwxh:0006� and others. Recent improvements including the migration into the health-lifesci extension has been led by the Healthcare Schema (�klzzwxh:0007�) community group at W3C. The health-lifesci schema.org extension is US healthcare insurance networks for other collaborative schema.org extensions in topics centred on healthcare, medicine and the lifesciences (e.g. see also �klzzwxh:0001�, and the �klzzwxh:0002� proposals for describing ).US healthcare insurance networks for other collaborative schema.org extensions in topics centred on healthcare, medicine and the lifesciences (e.g. see also �klzzwxh:0001�, and the �klzzwxh:0002� proposals for describing ).``

@danbri
Copy link
Contributor Author

@danbri danbri commented Aug 8, 2016

Thanks @twamarc - could you post a screenshot somewhere? e.g. http://imgur.com/ or email it...

@danbri
Copy link
Contributor Author

@danbri danbri commented Aug 8, 2016

Don't worry, I see it now. @RichardWallis and I are investigating.

@danbri
Copy link
Contributor Author

@danbri danbri commented Aug 8, 2016

Seems to be mis-processing of the markdown fragments in https://github.com/schemaorg/schemaorg/blob/sdo-makemake/data/extdefs.jsonld#L39

@danbri
Copy link
Contributor Author

@danbri danbri commented Aug 8, 2016

Unless we find some other flaw I suggest we leave things up until a quick fix is ready (rather than roll back to 3.0, which has many other deeper problems than 3.1).

@danbri
Copy link
Contributor Author

@danbri danbri commented Aug 8, 2016

Worst case we expand the markdown manually to make it readable before blogging, but hopefully @RichardWallis will figure out the bug.

@twamarc
Copy link
Contributor

@twamarc twamarc commented Aug 8, 2016

image

@twamarc
Copy link
Contributor

@twamarc twamarc commented Aug 8, 2016

ok! sorry posted the image before seeing your message. Ok Let's keep things as they are until a quick fix is ready. Thanks

@brewerdigital
Copy link

@brewerdigital brewerdigital commented Aug 8, 2016

@danbri
Copy link
Contributor Author

@danbri danbri commented Aug 8, 2016

Thanks @brewerdigital - I'm not sure the intention there. @vholland @gmackenz do you have a sense for where the rough consensus ended up? It certainly looks like Martin meant something different with that last edit.

The property does exist btw, http://schema.org/numberOfRooms however it looks like "The number of rooms (excluding bathrooms and closets) of the acccommodation or lodging business. Typical unit code(s): ROM for room or C62 for no unit. The type of room can be put in the unitText property of the QuantitativeValue." needs updating. I think part of the awkwardness here was the different counting conventions for hotels versus anticipated future work on real estate listings.

@danbri
Copy link
Contributor Author

@danbri danbri commented Aug 8, 2016

@twamarc et al., I've just deployed a quick fix from @RichardWallis that seems to have repaired http://health-lifesci.webschemas.org/ - we'll need to investigate whether other pages are also affected, it's an issue with the python markdown library we're using.

@danbri
Copy link
Contributor Author

@danbri danbri commented Aug 9, 2016

Martin Cook reports:

If I go here and click on a type in the hierarchy the site hangs:
http://webschemas.org/version/3.1/ 
Then I get : 

=================
Error: Server Error

The server encountered an error and could not complete your request.
Please try again in 30 seconds.

=================
Direct links from the release page work fine for me, though, and on poking around the pages look fine too.

I think that's from ... should it be /version/3.1/ ? @RichardWallis

danbri added a commit that referenced this issue Aug 9, 2016
@danbri
Copy link
Contributor Author

@danbri danbri commented Aug 9, 2016

I've committed a fix for that, and pushed to webschemas.org which now has working hyperlinks. I expect it will work on schema.org will won't update the site until @RichardWallis 's ready as we have markdown fixes to evaluate too.

@martin-nc
Copy link

@martin-nc martin-nc commented Aug 9, 2016

Thanks - links working fine for me now at http://webschemas.org/version/3.1/.

@danbri
Copy link
Contributor Author

@danbri danbri commented Aug 9, 2016

http://schema.org/version/3.1/ is update too now, seems ok.

On 9 August 2016 at 13:44, Martin Cook notifications@github.com wrote:

Thanks - links working fine for me now at http://webschemas.org/version/
3.1/.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#1212 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAKZGVO5UM1aRZcmV_xhbMkT3Y1rZnmcks5qeHY3gaJpZM4I4bb9
.

@danbri
Copy link
Contributor Author

@danbri danbri commented Aug 9, 2016

Ok, enough with the bugfixes. I think we're calling this done.

Blogged: http://blog.schema.org/2016/08/schemaorg-update-hotels-datasets-health.html

Thanks everyone!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
7 participants
You can’t perform that action at this time.