-
Notifications
You must be signed in to change notification settings - Fork 845
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Meta-issue for sdo-makemake release (likely as version 3.1) #1212
Comments
See http://webschemas.org/docs/releases.html for some more stuff that's in there. We are close to wrapping up hotels, and there is also some modest but useful polish around dataset description. |
Proposed for release c/o https://lists.w3.org/Archives/Public/public-schemaorg/2016Jul/0015.html |
Feedback received elsewhere in review (I'll edit this post)
Added extra:
|
Looks good to me. |
Looks good to me, too. martin hepp http://www.heppnetz.de
|
thanks! ping @scor @shankarnat @tmarshbing |
Relaying from @scor in 1:1 mail , "looks good!"
...and I heard from @shankarnat who is aiming to complete his review today (Aug 3rd). |
ping @shankarnat @tmarshbing |
Thanks Dan for Pinging me, looks good to me. |
Ok, all reviews are in. Thanks everyone! There are some modest todos listed above, and I'll make a final round of technical checks with @RichardWallis to try to avoid a repeat of the problems we had last time. Aiming for publication early next week! Thanks again :) |
I believe all the little fixes listed above are now correctly implemented. I'm sketching this for a release next week on Tuesday 9th August. |
via: curl http://localhost:8080/version/build-latest > schema-all.html Generated per RELEASING.TXT tweaking XX, and 'localhost' mentions. Note that MedicalBusiness leaked into the file somehow, I have commented it out manually. /cc #1212
Ok I have published tomorrow's release to http://schema.org/ Technically we are a few hours early, but it gives us time to verify that everything is functioning properly. Thanks everyone! |
A possible bug on home page text of `The schema.org '�klzzwxh:0004'� was �klzzwxh:0005� in collaboration with �klzzwxh:0006� and others. Recent improvements including the migration into the health-lifesci extension has been led by the Healthcare Schema (�klzzwxh:0007�) community group at W3C. The health-lifesci schema.org extension is US healthcare insurance networks for other collaborative schema.org extensions in topics centred on healthcare, medicine and the lifesciences (e.g. see also �klzzwxh:0001�, and the �klzzwxh:0002� proposals for describing ).US healthcare insurance networks for other collaborative schema.org extensions in topics centred on healthcare, medicine and the lifesciences (e.g. see also �klzzwxh:0001�, and the �klzzwxh:0002� proposals for describing ).`` |
Thanks @twamarc - could you post a screenshot somewhere? e.g. http://imgur.com/ or email it... |
Don't worry, I see it now. @RichardWallis and I are investigating. |
Seems to be mis-processing of the markdown fragments in https://github.com/schemaorg/schemaorg/blob/sdo-makemake/data/extdefs.jsonld#L39 |
Unless we find some other flaw I suggest we leave things up until a quick fix is ready (rather than roll back to 3.0, which has many other deeper problems than 3.1). |
Worst case we expand the markdown manually to make it readable before blogging, but hopefully @RichardWallis will figure out the bug. |
ok! sorry posted the image before seeing your message. Ok Let's keep things as they are until a quick fix is ready. Thanks |
Dan,
Since numberOfRooms didn't make the final build, can it be removed from the
dedicated documentation page examples?
#915 (comment)
"narrow down domain of numberOfRooms to House, Apartment, Suite and
SingleFamilyHome (to avoid e.g. Rooms to have a number of rooms property)"
Or was Martin trying to add it back in on Jun 23rd but had a typo by not
changing House text?
mfhepp@2d62bdb?diff=split
"added Hotel to domain of numberOfRooms"
Brad
|
Thanks @brewerdigital - I'm not sure the intention there. @vholland @gmackenz do you have a sense for where the rough consensus ended up? It certainly looks like Martin meant something different with that last edit. The property does exist btw, http://schema.org/numberOfRooms however it looks like "The number of rooms (excluding bathrooms and closets) of the acccommodation or lodging business. Typical unit code(s): ROM for room or C62 for no unit. The type of room can be put in the unitText property of the QuantitativeValue." needs updating. I think part of the awkwardness here was the different counting conventions for hotels versus anticipated future work on real estate listings. |
@twamarc et al., I've just deployed a quick fix from @RichardWallis that seems to have repaired http://health-lifesci.webschemas.org/ - we'll need to investigate whether other pages are also affected, it's an issue with the python markdown library we're using. |
Martin Cook reports:
I think that's from ... should it be /version/3.1/ ? @RichardWallis |
I've committed a fix for that, and pushed to webschemas.org which now has working hyperlinks. I expect it will work on schema.org will won't update the site until @RichardWallis 's ready as we have markdown fixes to evaluate too. |
Thanks - links working fine for me now at http://webschemas.org/version/3.1/. |
http://schema.org/version/3.1/ is update too now, seems ok. On 9 August 2016 at 13:44, Martin Cook notifications@github.com wrote:
|
Ok, enough with the bugfixes. I think we're calling this done. Blogged: http://blog.schema.org/2016/08/schemaorg-update-hotels-datasets-health.html Thanks everyone! |
This issue tracks release planning for schema.org's release codenamed sdo-makemake.
The release is codenamed after the dwarf planet Makemake, and because our focus for this release is primarily fixups:
The text was updated successfully, but these errors were encountered: