Product example 1 is missing itemprop="image" #1260

Closed
Scopestyle opened this Issue Jul 26, 2016 · 4 comments

Projects

None yet

4 participants

@Scopestyle

Hi!

Not sure if this is the right place to post but I would like to notify that the schema.org product page shows example 1 without the microdata itemprop="image", whereas example 2 shows the image correctly.

Kind regards,

Erik

@RichardWallis RichardWallis self-assigned this Jul 26, 2016
@RichardWallis
Contributor

Yes @Scopestyle you can 'notify' things like that here.

Strictly, as no properties are mandatory, the example you reference is OK markup. However as the example html does contain reference to an image, it does seem at least odd that it is not referenced with schema:image.

Will fix.

@Scopestyle

Cheers @RichardWallis, another thing I noticed that the introduction text on the Article page the link to the blog gets shown in an html block. I don't believe that this was meant to look this way. ๐Ÿ˜‰

@RichardWallis RichardWallis added a commit that referenced this issue Jul 26, 2016
@RichardWallis RichardWallis Update Example Product #eg-10
Addresses issue (#1260) Schema markup for image missing
6e7a797
@Dataliberate
Contributor

Fix now in Pull request #1261
#1261.

Problem with Article is fixed as part of PR #1222
#1222 and visible in
pre-release: http://webschemas.org/Article

~Richard.

Richard Wallis
Founder, Data Liberate
http://dataliberate.com
Linkedin: http://www.linkedin.com/in/richardwallis
Twitter: @rjw

On 26 July 2016 at 10:53, Scopestyle notifications@github.com wrote:

Cheers @RichardWallis https://github.com/RichardWallis, another thing I
noticed that the introduction text on the Article
https://schema.org/Article page the link to the blog gets shown in an
html block. I don't believe that this was meant to look this way. ๐Ÿ˜‰

โ€”
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#1260 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AHVdIOgJ6s9lw8Zo4Vc0WAcVOQv2WJcuks5qZdkOgaJpZM4JU9Qy
.

@danbri
Contributor
danbri commented Jul 31, 2016

Merged, thanks

@danbri danbri pushed a commit that referenced this issue Aug 1, 2016
Dan Brickley Noted fix for #1260 3731eed
@danbri danbri closed this Aug 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment