New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Product example 1 is missing itemprop="image" #1260

Closed
Scopestyle opened this Issue Jul 26, 2016 · 4 comments

Comments

Projects
None yet
4 participants
@Scopestyle

Scopestyle commented Jul 26, 2016

Hi!

Not sure if this is the right place to post but I would like to notify that the schema.org product page shows example 1 without the microdata itemprop="image", whereas example 2 shows the image correctly.

Kind regards,

Erik

@RichardWallis

This comment has been minimized.

Show comment
Hide comment
@RichardWallis

RichardWallis Jul 26, 2016

Contributor

Yes @Scopestyle you can 'notify' things like that here.

Strictly, as no properties are mandatory, the example you reference is OK markup. However as the example html does contain reference to an image, it does seem at least odd that it is not referenced with schema:image.

Will fix.

Contributor

RichardWallis commented Jul 26, 2016

Yes @Scopestyle you can 'notify' things like that here.

Strictly, as no properties are mandatory, the example you reference is OK markup. However as the example html does contain reference to an image, it does seem at least odd that it is not referenced with schema:image.

Will fix.

@Scopestyle

This comment has been minimized.

Show comment
Hide comment
@Scopestyle

Scopestyle Jul 26, 2016

Cheers @RichardWallis, another thing I noticed that the introduction text on the Article page the link to the blog gets shown in an html block. I don't believe that this was meant to look this way. 😉

Scopestyle commented Jul 26, 2016

Cheers @RichardWallis, another thing I noticed that the introduction text on the Article page the link to the blog gets shown in an html block. I don't believe that this was meant to look this way. 😉

RichardWallis added a commit that referenced this issue Jul 26, 2016

Update Example Product #eg-10
Addresses issue (#1260) Schema markup for image missing
@Dataliberate

This comment has been minimized.

Show comment
Hide comment
@Dataliberate

Dataliberate Jul 26, 2016

Contributor

Fix now in Pull request #1261
#1261.

Problem with Article is fixed as part of PR #1222
#1222 and visible in
pre-release: http://webschemas.org/Article

~Richard.

Richard Wallis
Founder, Data Liberate
http://dataliberate.com
Linkedin: http://www.linkedin.com/in/richardwallis
Twitter: @rjw

On 26 July 2016 at 10:53, Scopestyle notifications@github.com wrote:

Cheers @RichardWallis https://github.com/RichardWallis, another thing I
noticed that the introduction text on the Article
https://schema.org/Article page the link to the blog gets shown in an
html block. I don't believe that this was meant to look this way. 😉


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#1260 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AHVdIOgJ6s9lw8Zo4Vc0WAcVOQv2WJcuks5qZdkOgaJpZM4JU9Qy
.

Contributor

Dataliberate commented Jul 26, 2016

Fix now in Pull request #1261
#1261.

Problem with Article is fixed as part of PR #1222
#1222 and visible in
pre-release: http://webschemas.org/Article

~Richard.

Richard Wallis
Founder, Data Liberate
http://dataliberate.com
Linkedin: http://www.linkedin.com/in/richardwallis
Twitter: @rjw

On 26 July 2016 at 10:53, Scopestyle notifications@github.com wrote:

Cheers @RichardWallis https://github.com/RichardWallis, another thing I
noticed that the introduction text on the Article
https://schema.org/Article page the link to the blog gets shown in an
html block. I don't believe that this was meant to look this way. 😉


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#1260 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AHVdIOgJ6s9lw8Zo4Vc0WAcVOQv2WJcuks5qZdkOgaJpZM4JU9Qy
.

@danbri

This comment has been minimized.

Show comment
Hide comment
@danbri

danbri Jul 31, 2016

Contributor

Merged, thanks

Contributor

danbri commented Jul 31, 2016

Merged, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment