Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include schema:Product in range of schema:category #131

Closed
mfhepp opened this issue Sep 19, 2014 · 4 comments
Closed

Include schema:Product in range of schema:category #131

mfhepp opened this issue Sep 19, 2014 · 4 comments
Assignees
@danbri
Labels
guidelines docs examples Work on our supporting materials rather than on schema definitions schema.org vocab General top level tag for issues on the vocabulary
Milestone
sdo-gozer release

Comments

@mfhepp
Copy link
Contributor

mfhepp commented Sep 19, 2014

When we integrated GoodRelations, we skipped the category property for reasons I do not remember.

This should be fixed - simply add
<span>Domain: <a property="http://schema.org/domainIncludes" href="http://schema.org/Product">Product</a></span>

in the block for

<div typeof="rdf:Property" resource="http://schema.org/category">

This will also make this consistent with

http://www.heppnetz.de/ontologies/goodrelations/v1.html#category
@scor
Copy link
Contributor

scor commented Sep 19, 2014

@mfhepp FYI some of your markup didn't make it through the markdown parser. use triple backtick ```

@mfhepp
Copy link
Contributor Author

mfhepp commented Sep 20, 2014

Thanks, fixed.

Sachini added a commit to Sachini/schemaorg that referenced this issue Sep 21, 2014
@Sachini
Fixes schemaorg#131 -Include schema:Product in domain of schema:category
1bd2e79
@danbri danbri added guidelines docs examples Work on our supporting materials rather than on schema definitions needs review schema.org vocab General top level tag for issues on the vocabulary labels Jan 21, 2015
@danbri danbri added this to the sdo-gozer release milestone Jan 21, 2015
@danbri danbri self-assigned this Jan 21, 2015
@mfhepp
Copy link
Contributor Author

mfhepp commented Mar 26, 2015

I fixed the title, because it was about the domain, not the range of the property.

@danbri
Copy link
Contributor

danbri commented Apr 16, 2015

see also #160

This was referenced Apr 16, 2015
Closed
Closed
@jaw111 jaw111 mentioned this issue Apr 22, 2015
Closed
@danbri danbri closed this as completed in b92500d Apr 30, 2015
@danbri danbri mentioned this issue Jun 20, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danbri danbri

Labels
guidelines docs examples Work on our supporting materials rather than on schema definitions schema.org vocab General top level tag for issues on the vocabulary
Projects
None yet
Milestone
sdo-gozer release
Development

No branches or pull requests
3 participants
@scor @danbri @mfhepp