Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

`timeRequired` examples show invalid values. #1469

Closed
christianhujer opened this issue Jan 9, 2017 · 1 comment

Comments

Projects
None yet
3 participants
@christianhujer
Copy link

commented Jan 9, 2017

The timeRequired example given 'P30M' probably shall mean "30 minutes". However, 'P30M' actually means a duration of 30 months, which I do not think was the intention. The correct way to specify a duration of 30 minutes is 'PT30M'.

The timeRequired example given 'P1H25M' is invalid, as "P1H25M" is not a valid duration string. The correct way to specify a duration of 1 hour and 25 minutes is 'PT1H25M'.

The timeRequired property: http://schema.org/timeRequired
Description of ISO8601 durations: https://en.wikipedia.org/wiki/ISO_8601#Durations

philbarker added a commit to philbarker/schemaorg that referenced this issue Jan 10, 2017

philbarker added a commit to philbarker/schemaorg that referenced this issue Oct 19, 2017

philbarker added a commit to philbarker/schemaorg that referenced this issue Jun 26, 2018

philbarker added a commit to philbarker/schemaorg that referenced this issue Jun 26, 2018

@danbri danbri closed this in 5f99c67 Oct 23, 2018

@philbarker

This comment has been minimized.

Copy link
Contributor

commented Feb 21, 2019

@danbri I think this reopening too? I screwed up putting a fix for this issue into an unrelated branch, then reverted the fix, but the PR closed this issue because of the original commit.
PR #1975 closes this issue properly.

danbri added a commit that referenced this issue Apr 2, 2019

fixes to timeRequired (#1975)
* correcting format of durations, fixes #1470

* correcting examples in timeRequired. Fixes #1469
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.