Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

`timeRequired` RDFa example uses invalid (ambiguous) duration #1470

Closed
christianhujer opened this issue Jan 9, 2017 · 1 comment

Comments

Projects
None yet
3 participants
@christianhujer
Copy link

commented Jan 9, 2017

The RDFa example for timeRequired contains the following HTML+RDFa fragment:

        Duration: <span property="duration">03:12</span>

This is ambiguous and therefore invalid: A tool wouldn't know whether the 03:12 represents 3 hours 12 minutes or 3 minutes 12 seconds. The corresponding HTML+RDFa should look like this:

Duration: <time property="duration" datetime="PT3H12M" content="PT3H12M">03:12</time>

Similarly, the markup for the following fragment of the same example should be improved:

       Typical length of lesson, <span property="timeRequired">1 hour</span>. 

to

       Typical length of lesson, <time property="timeRequired" datetime="PT1H" content="PT1H">1 hour</time>. 

philbarker added a commit to philbarker/schemaorg that referenced this issue Jan 10, 2017

philbarker added a commit to philbarker/schemaorg that referenced this issue Oct 19, 2017

philbarker added a commit to philbarker/schemaorg that referenced this issue Jun 26, 2018

philbarker added a commit to philbarker/schemaorg that referenced this issue Jun 26, 2018

@danbri danbri closed this in 5f99c67 Oct 23, 2018

@philbarker

This comment has been minimized.

Copy link
Contributor

commented Feb 21, 2019

@danbri I think this reopening ? I screwed up putting a fix for this issue into an unrelated branch, then reverted the fix, but the PR closed this issue because of the original commit.
PR #1975 closes this issue properly.

danbri added a commit that referenced this issue Apr 2, 2019

fixes to timeRequired (#1975)
* correcting format of durations, fixes #1470

* correcting examples in timeRequired. Fixes #1469
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.