Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

timeRequired RDFa example uses invalid (ambiguous) duration #1470

Closed
christianhujer opened this issue Jan 9, 2017 · 1 comment
Closed

timeRequired RDFa example uses invalid (ambiguous) duration #1470

christianhujer opened this issue Jan 9, 2017 · 1 comment
Labels
Fixed Awaiting Release Fixed in main branch / posted to webschemas.org site / proposed for inclusion in next release

Comments

@christianhujer
Copy link

The RDFa example for timeRequired contains the following HTML+RDFa fragment:

        Duration: <span property="duration">03:12</span>

This is ambiguous and therefore invalid: A tool wouldn't know whether the 03:12 represents 3 hours 12 minutes or 3 minutes 12 seconds. The corresponding HTML+RDFa should look like this:

Duration: <time property="duration" datetime="PT3H12M" content="PT3H12M">03:12</time>

Similarly, the markup for the following fragment of the same example should be improved:

       Typical length of lesson, <span property="timeRequired">1 hour</span>. 

to

       Typical length of lesson, <time property="timeRequired" datetime="PT1H" content="PT1H">1 hour</time>. 
philbarker pushed a commit to philbarker/schemaorg that referenced this issue Jan 10, 2017
philbarker pushed a commit to philbarker/schemaorg that referenced this issue Oct 19, 2017
philbarker pushed a commit to philbarker/schemaorg that referenced this issue Jun 26, 2018
philbarker added a commit to philbarker/schemaorg that referenced this issue Jun 26, 2018
@danbri danbri closed this as completed in 5f99c67 Oct 23, 2018
@philbarker
Copy link
Contributor

@danbri I think this reopening ? I screwed up putting a fix for this issue into an unrelated branch, then reverted the fix, but the PR closed this issue because of the original commit.
PR #1975 closes this issue properly.

danbri pushed a commit that referenced this issue Apr 2, 2019
* correcting format of durations, fixes #1470

* correcting examples in timeRequired. Fixes #1469
@RichardWallis RichardWallis added the Fixed Awaiting Release Fixed in main branch / posted to webschemas.org site / proposed for inclusion in next release label Apr 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fixed Awaiting Release Fixed in main branch / posted to webschemas.org site / proposed for inclusion in next release
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants