Consider menuAddOn property (+move proposed design into Pending) #1541

Open
danbri opened this Issue Mar 2, 2017 · 8 comments

Comments

Projects
None yet
5 participants
@danbri
Contributor

danbri commented Mar 2, 2017

Spin-off from discussion in #1288 around menus and menu items: the proposed menuAddOn piece of that design needs further discussion.

http://webschemas.org/menuAddOn

"Additional menu item(s) such as a side dish of salad or side order of fries that can be added to this menu item. Additionally it can be a menu section containing allowed add-on menu items for this menu item."

Per #1288, decision is to move that property into Pending, the rest has rough consensus and is going directly into Core.

/cc @gmackenz

@gmackenz

This comment has been minimized.

Show comment
Hide comment
@gmackenz

gmackenz Mar 2, 2017

Contributor
Contributor

gmackenz commented Mar 2, 2017

@danbri

This comment has been minimized.

Show comment
Hide comment
@danbri

danbri Mar 2, 2017

Contributor

http://webschemas.org/menuAddOn should reflect this change imminently.

Contributor

danbri commented Mar 2, 2017

http://webschemas.org/menuAddOn should reflect this change imminently.

@DDeering

This comment has been minimized.

Show comment
Hide comment
@DDeering

DDeering May 4, 2017

I know it's pending and I hate to be a stickler about it, but I'm still against using "menuAddOn" as the name of the property. The term implies that something is being added to the menu. But we're not using it to add something to a menu, we're adding something to a menu item. So, wouldn't something like "menuItemAddOn" or "itemAddOn" be a more appropriate name for the property?

I apologize, @danbri and @gmackenz but I just think that the proposed property name would be confusing to users and wouldn't appropriately reflect its intended use.

DDeering commented May 4, 2017

I know it's pending and I hate to be a stickler about it, but I'm still against using "menuAddOn" as the name of the property. The term implies that something is being added to the menu. But we're not using it to add something to a menu, we're adding something to a menu item. So, wouldn't something like "menuItemAddOn" or "itemAddOn" be a more appropriate name for the property?

I apologize, @danbri and @gmackenz but I just think that the proposed property name would be confusing to users and wouldn't appropriately reflect its intended use.

@thadguidry

This comment has been minimized.

Show comment
Hide comment
@thadguidry

thadguidry May 5, 2017

@DDeering

This comment has been minimized.

Show comment
Hide comment
@DDeering

DDeering May 22, 2017

@danbri Could we move forward with this property but name it "itemAddOn" instead of "menuAddOn"?

@danbri Could we move forward with this property but name it "itemAddOn" instead of "menuAddOn"?

@gmackenz

This comment has been minimized.

Show comment
Hide comment
@gmackenz

gmackenz May 22, 2017

Contributor

I wonder if 'itemAddOn' isn't just as confusable with 'addOn', I am not opposed to the notion of renaming to menuItemAddOn. That said, I don't think this is ever leaving pending anytime soon.

Contributor

gmackenz commented May 22, 2017

I wonder if 'itemAddOn' isn't just as confusable with 'addOn', I am not opposed to the notion of renaming to menuItemAddOn. That said, I don't think this is ever leaving pending anytime soon.

@DDeering

This comment has been minimized.

Show comment
Hide comment
@DDeering

DDeering May 22, 2017

Personally, I think that "itemAddOn" is rather clear and straightforward but I'm open to calling it whatever the majority chooses as long as it's not "menuAddOn" for the reasons I mentioned above.

Personally, I think that "itemAddOn" is rather clear and straightforward but I'm open to calling it whatever the majority chooses as long as it's not "menuAddOn" for the reasons I mentioned above.

@blerimj

This comment has been minimized.

Show comment
Hide comment
@blerimj

blerimj Jul 24, 2017

How do you solve the problem of MenuItem having multiple size offerings. I.e. Cheese Pizza small , Cheese Pizza Large and the price of toppings (menuItemAddOns) depend on the selection - small or large.

blerimj commented Jul 24, 2017

How do you solve the problem of MenuItem having multiple size offerings. I.e. Cheese Pizza small , Cheese Pizza Large and the price of toppings (menuItemAddOns) depend on the selection - small or large.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment