Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider menuAddOn property (+move proposed design into Pending) #1541

Closed
danbri opened this issue Mar 2, 2017 · 10 comments
Closed

Consider menuAddOn property (+move proposed design into Pending) #1541

danbri opened this issue Mar 2, 2017 · 10 comments

Comments

@danbri
Copy link
Contributor

@danbri danbri commented Mar 2, 2017

Spin-off from discussion in #1288 around menus and menu items: the proposed menuAddOn piece of that design needs further discussion.

http://webschemas.org/menuAddOn

"Additional menu item(s) such as a side dish of salad or side order of fries that can be added to this menu item. Additionally it can be a menu section containing allowed add-on menu items for this menu item."

Per #1288, decision is to move that property into Pending, the rest has rough consensus and is going directly into Core.

/cc @gmackenz

@gmackenz
Copy link
Contributor

@gmackenz gmackenz commented Mar 2, 2017

danbri added a commit that referenced this issue Mar 2, 2017
@danbri
Copy link
Contributor Author

@danbri danbri commented Mar 2, 2017

http://webschemas.org/menuAddOn should reflect this change imminently.

@DDeering
Copy link

@DDeering DDeering commented May 4, 2017

I know it's pending and I hate to be a stickler about it, but I'm still against using "menuAddOn" as the name of the property. The term implies that something is being added to the menu. But we're not using it to add something to a menu, we're adding something to a menu item. So, wouldn't something like "menuItemAddOn" or "itemAddOn" be a more appropriate name for the property?

I apologize, @danbri and @gmackenz but I just think that the proposed property name would be confusing to users and wouldn't appropriately reflect its intended use.

@thadguidry
Copy link
Contributor

@thadguidry thadguidry commented May 5, 2017

@DDeering
Copy link

@DDeering DDeering commented May 22, 2017

@danbri Could we move forward with this property but name it "itemAddOn" instead of "menuAddOn"?

@gmackenz
Copy link
Contributor

@gmackenz gmackenz commented May 22, 2017

I wonder if 'itemAddOn' isn't just as confusable with 'addOn', I am not opposed to the notion of renaming to menuItemAddOn. That said, I don't think this is ever leaving pending anytime soon.

@DDeering
Copy link

@DDeering DDeering commented May 22, 2017

Personally, I think that "itemAddOn" is rather clear and straightforward but I'm open to calling it whatever the majority chooses as long as it's not "menuAddOn" for the reasons I mentioned above.

@blerimj
Copy link

@blerimj blerimj commented Jul 24, 2017

How do you solve the problem of MenuItem having multiple size offerings. I.e. Cheese Pizza small , Cheese Pizza Large and the price of toppings (menuItemAddOns) depend on the selection - small or large.

@danbri
Copy link
Contributor Author

@danbri danbri commented Feb 19, 2019

itemAddOn doesn't work well, since it is too generic and this property is all about menus and food

We are seeing it on a fair number of sites. It is a tiny change left over from the other menu work, let's stick it in the core rather than leaving it dangling.

@danbri danbri closed this in a584fc0 Feb 19, 2019
@RichardWallis
Copy link
Contributor

@RichardWallis RichardWallis commented Apr 10, 2019

Implemented in release 3.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
6 participants
You can’t perform that action at this time.