-
Notifications
You must be signed in to change notification settings - Fork 820
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up Comment vs UserComments vs CommentAction #170
Comments
Here is a generalization of this issue: #172 |
I think for body of the comment one can use: http://schema.org/text "The textual content of this CreativeWork." |
Good point, re: schema.org/text. We need better examples so authors know to use that property. |
👍 writing more examples! To get started I'll prepare another PR with example I send out to mailing list. It uses Comment as result of CommentAction: http://lists.w3.org/Archives/Public/public-vocabs/2014Nov/0101.html |
SGTM On Wed, Nov 19, 2014 at 8:10 AM, ☮ elf Pavlik ☮ notifications@github.com
f u cn rd ths u cn b a gd prgmr ! |
Noting discussion in #137 and expectation that interactionCount will go away. Shall we monitor that departure here? |
SGTM. I would like to take this up again once sdo-gozer is complete. |
Oh, I was talking about closing #137 since it is somewhat covered by this issue #170, which I thought we would try to address during gozer. Do we have rough consensus that
I believe this issue tracks the "what to do about Comment vs CommentAction's relationship", and #138 tracks everything else relating to removal of the UserInteraction terms. |
…p://schema.org/comment, added http://schema.org/resultComment, and deprecated http://schema.org/language. Remaining work is to deprecate UserInteraction and all of its children and http://schema.org/interactionCount.
I'm trying to make progress on this. I created pull request #466, which:
@danbri Once we have decided on how to deprecate without replacement, I would like to deprecate UserInteraction and its children, including UserComments as mentioned in issue #138. /cc @elf-pavlik who I don't see on this thread, but has expressed interest in other, overlapping threads. |
Do you plan to create for each FooAction type a matching resultFoo property? ATM I really don't understand why not simply use generic result. |
@elf-pavlik It's not my intention to create a resultFoo for every FooAction, but I think it is useful to have subproperties where people will almost certainly want a result of a specific type. The Action model can be confusing for authors, so handholding on common use cases can be helpful. |
Issue #170: Removed UserComments as an expected type for http://schema.o...
Thanks @vholland. I've merged this initial step, and updated docs/releases.html to remember what we did. The language/inLanguage one might be a good nudge for us to document how to use controlled strings vs Language and properties (which?) of that type. I'll leave this issue open as we have a bit more yet to do on deprecation via #465. |
http://sdo-gozer.appspot.com/docs/releases.html#sdo-gozer I've updated the issue description above with some final TODOs |
I'm going to close this. For now the deprecation is handled in human-facing text. We have other bugs tracking deprecation-related infrastructure so I'll close this. Thanks all! |
Please forgive me if this isn't the right place for this question, but do the changes enacted here basically result in this change of markup? |
Yes. Thanks for the example! |
http://schema.org/Comment
http://schema.org/CommentAction
http://schema.org/UserComments
Schema.org currently has three overlapping types:
Comment: A subtype of CreativeWork described as "A comment on an item". Oddly enough, it does not allow for including the body of the comment. One can only describe the comment (e.g. author, date published, etc.)
CommentAction: "The act of generating a comment about a subject." It also does not include the body of the comment.
UserComments: A subtype of UserInteraction. It is the "event" of commenting. The only way to include the comment body.
The only place where Comment and UserComments are used as an expected type is on the "comment" property of CreativeWork.
This is all very confusing and should be cleaned up.
Status (May 1) for sdo-gozer
TODOs before closing this issue
The text was updated successfully, but these errors were encountered: