New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add domainIncludes RsvpAction to comment property #183

Closed
danbri opened this Issue Nov 21, 2014 · 2 comments

Comments

Projects
None yet
1 participant
@danbri
Contributor

danbri commented Nov 21, 2014

http://schema.org/RsvpAction

It has been suggested that RsvpAction descriptions would benefit from having ability to associate a comment.

See also a similiar point in #300 and ReplyAction and Answer from @vholland

@danbri danbri self-assigned this Nov 21, 2014

@danbri danbri added this to the sdo-stantz release milestone Nov 21, 2014

@danbri danbri changed the title from Add domainIncludes comment to RsvpAction to Add domainIncludes RsvpAction to comment property Nov 21, 2014

@danbri

This comment has been minimized.

Show comment
Hide comment
@danbri

danbri Feb 7, 2015

Contributor

In the spirit of re-using rather than duplicating our existing noun-oriented types, I think we should do this. Queueing an implementation for sdo-gozer. I'm also modernizing its range to permit Comment type as a value (long overdue). Definitions would then be:

<div typeof="rdf:Property" resource="http://schema.org/comment">
  <span class="h" property="rdfs:label">comment</span>
  <span property="rdfs:comment">Comments, typically from users, on this CreativeWork.</span>
  <span>Domain: <a property="http://schema.org/domainIncludes" href="http://schema.org/CreativeWork">CreativeWork</a></span>
  <span>Domain: <a property="http://schema.org/domainIncludes" href="http://schema.org/RsvpAction">RsvpAction</a></span>
  <span>Range: <a property="http://schema.org/rangeIncludes" href="http://schema.org/UserComments">UserComments</a></span>
  <span>Range: <a property="http://schema.org/rangeIncludes" href="http://schema.org/Comment">Comment</a></span>
</div>
Contributor

danbri commented Feb 7, 2015

In the spirit of re-using rather than duplicating our existing noun-oriented types, I think we should do this. Queueing an implementation for sdo-gozer. I'm also modernizing its range to permit Comment type as a value (long overdue). Definitions would then be:

<div typeof="rdf:Property" resource="http://schema.org/comment">
  <span class="h" property="rdfs:label">comment</span>
  <span property="rdfs:comment">Comments, typically from users, on this CreativeWork.</span>
  <span>Domain: <a property="http://schema.org/domainIncludes" href="http://schema.org/CreativeWork">CreativeWork</a></span>
  <span>Domain: <a property="http://schema.org/domainIncludes" href="http://schema.org/RsvpAction">RsvpAction</a></span>
  <span>Range: <a property="http://schema.org/rangeIncludes" href="http://schema.org/UserComments">UserComments</a></span>
  <span>Range: <a property="http://schema.org/rangeIncludes" href="http://schema.org/Comment">Comment</a></span>
</div>
@danbri

This comment has been minimized.

Show comment
Hide comment
@danbri

danbri Apr 16, 2015

Contributor

Per discussion on the commit, one final change:

  • "Comments, typically from users, on this CreativeWork." becomes "Comments, typically from users."
Contributor

danbri commented Apr 16, 2015

Per discussion on the commit, one final change:

  • "Comments, typically from users, on this CreativeWork." becomes "Comments, typically from users."
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment