New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Acomodation type has 2 "amenityFeature" properties on the downloadable csv file #1879

Closed
khalyomede opened this Issue Apr 2, 2018 · 4 comments

Comments

Projects
None yet
2 participants
@khalyomede

khalyomede commented Apr 2, 2018

On the file downlodable at http://schema.org/version/latest/all-layers-types.csv, the type http://schema.org/Accommodation type has 2 properties http://schema.org/amenityFeature.

Is this an actual bug or it this intentional?

@RichardWallis

This comment has been minimized.

Contributor

RichardWallis commented Apr 3, 2018

Well spotted @khalyomede

After some digging it seems that amenityFeature was unnecessarily defined as a property for Accommodation, as it is already defined for Place from which it inherits.

I will register this as a defect as it at least should have raised a warning or similar.

@RichardWallis

This comment has been minimized.

Contributor

RichardWallis commented Apr 13, 2018

Candidate for a new test to identify the unnecessary declaration of a property for a type, where the property is already inherited from a supertype.

@RichardWallis

This comment has been minimized.

Contributor

RichardWallis commented Apr 15, 2018

Built new test to check for unnecessary domainIncludes statements. ie. Where a property is defined for a type, that is already defined in, and therefore inherited from, a supertype.

Results show 31 errors:

test_unnecessaryDomainIncludes (test_graphs.SDOGraphSetupTestCase) ... INFO:test_graphs:Unnecessary Domain Includes errors!!!

INFO:test_graphs:Property 'actionableFeedbackPolicy' has unneccesary domainInclude of type 'NewsMediaOrganization' - aready inherited from 'Organization'
INFO:test_graphs:Property 'activeIngredient' has unneccesary domainInclude of type 'DietarySupplement' - aready inherited from 'Substance'
INFO:test_graphs:Property 'activeIngredient' has unneccesary domainInclude of type 'Drug' - aready inherited from 'Substance'
INFO:test_graphs:Property 'alumni' has unneccesary domainInclude of type 'EducationalOrganization' - aready inherited from 'Organization'
INFO:test_graphs:Property 'amenityFeature' has unneccesary domainInclude of type 'Accommodation' - aready inherited from 'Place'
INFO:test_graphs:Property 'amenityFeature' has unneccesary domainInclude of type 'LodgingBusiness' - aready inherited from 'Place'
INFO:test_graphs:Property 'cause' has unneccesary domainInclude of type 'MedicalSignOrSymptom' - aready inherited from 'MedicalCondition'
INFO:test_graphs:Property 'codeValue' has unneccesary domainInclude of type 'MedicalCode' - aready inherited from 'CategoryCode'
INFO:test_graphs:Property 'correctionsPolicy' has unneccesary domainInclude of type 'NewsMediaOrganization' - aready inherited from 'Organization'
INFO:test_graphs:Property 'diversityPolicy' has unneccesary domainInclude of type 'NewsMediaOrganization' - aready inherited from 'Organization'
INFO:test_graphs:Property 'diversityStaffingReport' has unneccesary domainInclude of type 'NewsMediaOrganization' - aready inherited from 'Organization'
INFO:test_graphs:Property 'duration' has unneccesary domainInclude of type 'Audiobook' - aready inherited from 'MediaObject'
INFO:test_graphs:Property 'ethicsPolicy' has unneccesary domainInclude of type 'NewsMediaOrganization' - aready inherited from 'Organization'
INFO:test_graphs:Property 'healthCondition' has unneccesary domainInclude of type 'Patient' - aready inherited from 'PeopleAudience'
INFO:test_graphs:Property 'indication' has unneccesary domainInclude of type 'TherapeuticProcedure' - aready inherited from 'MedicalProcedure'
INFO:test_graphs:Property 'isAccessibleForFree' has unneccesary domainInclude of type 'PublicationEvent' - aready inherited from 'Event'
INFO:test_graphs:Property 'legalStatus' has unneccesary domainInclude of type 'Drug' - aready inherited from 'MedicalEntity'
INFO:test_graphs:Property 'legalStatus' has unneccesary domainInclude of type 'DietarySupplement' - aready inherited from 'MedicalEntity'
INFO:test_graphs:Property 'maximumIntake' has unneccesary domainInclude of type 'Drug' - aready inherited from 'Substance'
INFO:test_graphs:Property 'maximumIntake' has unneccesary domainInclude of type 'DietarySupplement' - aready inherited from 'Substance'
INFO:test_graphs:Property 'medicalSpecialty' has unneccesary domainInclude of type 'Hospital' - aready inherited from 'MedicalOrganization'
INFO:test_graphs:Property 'medicalSpecialty' has unneccesary domainInclude of type 'Physician' - aready inherited from 'MedicalOrganization'
INFO:test_graphs:Property 'medicalSpecialty' has unneccesary domainInclude of type 'MedicalClinic' - aready inherited from 'MedicalOrganization'
INFO:test_graphs:Property 'numberOfRooms' has unneccesary domainInclude of type 'House' - aready inherited from 'Accommodation'
INFO:test_graphs:Property 'numberOfRooms' has unneccesary domainInclude of type 'Apartment' - aready inherited from 'Accommodation'
INFO:test_graphs:Property 'numberOfRooms' has unneccesary domainInclude of type 'SingleFamilyResidence' - aready inherited from 'Accommodation'
INFO:test_graphs:Property 'numberOfRooms' has unneccesary domainInclude of type 'Suite' - aready inherited from 'Accommodation'
INFO:test_graphs:Property 'numberOfRooms' has unneccesary domainInclude of type 'SingleFamilyResidence' - aready inherited from 'House'
INFO:test_graphs:Property 'ownershipFundingInfo' has unneccesary domainInclude of type 'NewsMediaOrganization' - aready inherited from 'Organization'
INFO:test_graphs:Property 'possibleTreatment' has unneccesary domainInclude of type 'MedicalSignOrSymptom' - aready inherited from 'MedicalCondition'
INFO:test_graphs:Property 'productionDate' has unneccesary domainInclude of type 'Vehicle' - aready inherited from 'Product'
INFO:test_graphs:Property 'purchaseDate' has unneccesary domainInclude of type 'Vehicle' - aready inherited from 'Product'
INFO:test_graphs:Property 'unnamedSourcesPolicy' has unneccesary domainInclude of type 'NewsMediaOrganization' - aready inherited from 'Organization'

Question now arrises -- do we fix all these now, or leave them in tests as 'expected failures' for later fixing?

/cc @danbri

RichardWallis pushed a commit that referenced this issue May 2, 2018

Fix to duplicate and missing properties listings in the CSV outputs f…
…or Types and Enumeratin values.

Issues (#1882) and (#1879)
The contents of the -enumvalues.csv output file have been merged into the -types.csv files.
Download option for -enumvalues.csv removed.
@RichardWallis

This comment has been minimized.

Contributor

RichardWallis commented Jun 15, 2018

Released in V3.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment