Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some "MedicalTestPanel" sub-type missing from csv file #1882

Closed
khalyomede opened this Issue Apr 3, 2018 · 5 comments

Comments

Projects
None yet
4 participants
@khalyomede
Copy link

khalyomede commented Apr 3, 2018

The following types are missing from csv file http://schema.org/version/latest/all-layers-types.csv:

  • http://schema.org/OccupationalTherapy
  • http://schema.org/RespiratoryTherapy

This property is a sub-type of http://schema.org/MedicalTestPanel.

@khalyomede khalyomede changed the title Type "OccupationalTherapy" does not exists in csv file (which is a sub-type of "MedicalTestPanel" Some "MedicalTestPanel" sub-type missing from csv file Apr 3, 2018

@RichardWallis

This comment has been minimized.

Copy link
Contributor

RichardWallis commented Apr 4, 2018

I've had a look at the csv and indeed there is something odd.

OccupationalTherapy and RespiratoryTherapy are subtypes of MedicalTherapy, yet when inspecting their reference pages [1], [2] they appear to be enumeration values for MedicalSpecialty.

Things seem to be reported similarly in the equivalent Turtle file:

schema:OccupationalTherapy a schema:MedicalSpecialty ;
    rdfs:label "OccupationalTherapy" ;
    schema:isPartOf <http://health-lifesci.schema.org> ;
    rdfs:comment "A treatment of people with physical, emotional, or social problems, using purposeful activity to help them overcome or learn to deal with their problems." ;
    rdfs:subClassOf schema:MedicalTherapy .

"schema:OccupationalTherapy a schema:MedicalSpecialty" yet "rdfs:subClassOf schema:MedicalTherapy" - doesn't seem to make sense, it needs looking into deeper to see if it is a term definition problem or an issue in the way that the processes that output these files are interpreting enumeration values correctly.

I will label this as a bug.

@twamarc

This comment has been minimized.

Copy link
Contributor

twamarc commented Apr 4, 2018

I agree @RichardWallis , this seems to be unfixed bug since the migration.
rdfs:subClassOf schema:MedicalTherapy is correct.
schema:OccupationalTherapy a schema:MedicalSpecialty should be droped
Here we confused the wording with OccupationalMedicine [not in schema.org] which is a MedicalSpecialty.

I suggest to fix this asap -just like the PhysicalTherapy (they are both children of MedicalTherapy)

Suggested fix:
Current .rdfa file part for this:

<div typeof="http://schema.org/MedicalSpecialty" resource="http://schema.org/OccupationalTherapy">
  <span class="h" property="rdfs:label">OccupationalTherapy</span>
  <span property="rdfs:comment">A treatment of people with physical, emotional, or social problems, using purposeful activity to help them overcome or learn to deal with their problems.</span>
  <span>Subclass of: <a property="rdfs:subClassOf" href="http://schema.org/MedicalTherapy">MedicalTherapy</a></span>
<link property="http://schema.org/isPartOf" href="http://health-lifesci.schema.org" />
</div>

New .rdfa file part to replace the existing:

*<div typeof="rdfs:Class" resource="http://schema.org/OccupationalTherapy">*
  <span class="h" property="rdfs:label">OccupationalTherapy</span>
  <span property="rdfs:comment">A treatment of people with physical, emotional, or social problems, using purposeful activity to help them overcome or learn to deal with their problems.</span>
  <span>Subclass of: <a property="rdfs:subClassOf" href="http://schema.org/MedicalTherapy">MedicalTherapy</a></span>
<link property="http://schema.org/isPartOf" href="http://health-lifesci.schema.org" />
</div>

If you agree I can prepare a PR.

@danbri

This comment has been minimized.

Copy link
Contributor

danbri commented Apr 9, 2018

@RichardWallis can you generalize from this bug to a new unit test? It seems like the kind of mistake we ought to be programmatically checking for by now.

@RichardWallis RichardWallis self-assigned this Apr 9, 2018

@RichardWallis

This comment has been minimized.

Copy link
Contributor

RichardWallis commented Apr 9, 2018

Will do.

RichardWallis pushed a commit that referenced this issue May 2, 2018

Richard Wallis
Fix to OccupationalTherapy
Made OccupationalTherapy a simple class instead of a typeof schema:MedicalSpecialty
Issue (#1882)

RichardWallis pushed a commit that referenced this issue May 2, 2018

Fix to duplicate and missing properties listings in the CSV outputs f…
…or Types and Enumeratin values.

Issues (#1882) and (#1879)
The contents of the -enumvalues.csv output file have been merged into the -types.csv files.
Download option for -enumvalues.csv removed.
@RichardWallis

This comment has been minimized.

Copy link
Contributor

RichardWallis commented Jun 15, 2018

Released in V3.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.