Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend the range of contentRating to include Rating #1935

Closed
vholland opened this issue Jun 5, 2018 · 3 comments
Closed

Extend the range of contentRating to include Rating #1935

vholland opened this issue Jun 5, 2018 · 3 comments
Assignees

Comments

@vholland
Copy link
Contributor

@vholland vholland commented Jun 5, 2018

Currently http://schema.org/contentRating expects a Text value like 'MPAA PG-13'. It would be nice to follow the example of http://schema.org/starRating and extend the range of contentRating to allow for a http://schema.org/Rating. That way we could be explicit about the rating organization and the rating value.

@danbri
Copy link
Contributor

@danbri danbri commented Jun 6, 2018

Good point. We should do this. /cc @tmarshbing @tilid @scor @rvguha @nicolastorzec

@Aaranged
Copy link

@Aaranged Aaranged commented Jun 6, 2018

+1! Just to provide a use case both the South African Film & Publication Board and the British Board of Film Classification have the content rating "18". This value is obviously a lot more meaningful if it can be connected to the originating rating organization.

danbri added a commit that referenced this issue Jun 6, 2018
@danbri
Copy link
Contributor

@danbri danbri commented Jun 6, 2018

Done. This didn't seem to be one for standing upon ceremony...

espinr pushed a commit to espinr/schemaorg that referenced this issue Jun 7, 2018
* 'master' of https://github.com/schemaorg/schemaorg: (76 commits)
  Added tests for correct operation of traverseForHTML & traverseForJSONLD functions
  Updated for contentRating / Rating tweak.
  Added Rating as expected of contentRating, for schemaorg#1935 Thanks @vholland!
  Noted alias of HTML from rdf:HTML, schemaorg#1634
  alias HTML to rdf:HTML (schemaorg#1634)
  Obvious 404 fixes from issue (schemaorg#1901) (schemaorg#1930)
  Changes to move to https only (for UI, not for vocab URIs) (schemaorg#1932)
  Fix to docs/tree.jsonld causing crash
  2018 -> 2017, fixes schemaorg#1929 Thanks @Aaranged :)
  Removed duplicate entries, and added a summary. schemaorg#1891
  Updated to cover all changes in 3.4.
  More release notes.
  Added lots of release notes, converted from git.
  Update releases.html
  One-liner for creating release note entries.
  Working on conversion of 900+ lines of changes into release note format. For schemaorg#1891 release 3.4.
  Tweaks to image tag, changed "mp4" to "jpg", added alt. /cc schemaorg#1922
  Small fix to howto html samples (schemaorg#1922)
  Fixes for the HowTo sample (schemaorg#1919)
  Fix physician subclass (schemaorg#1911)
  ...

# Conflicts:
#	app.yaml
@vholland vholland self-assigned this Oct 19, 2018
@vholland vholland closed this Nov 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants