Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow byArtist to accept a Person as well as a MusicGroup #2020

Open
vholland opened this Issue Jul 24, 2018 · 5 comments

Comments

Projects
None yet
3 participants
@vholland
Copy link
Contributor

vholland commented Jul 24, 2018

http://schema.org/MusicAlbum and http://schema.org/MusicRecording use http://schema.org/byArtist to designate the artist credited with an album. Currently, the only acceptable type is http://schema.org/MusicGroup.

While MusicGroup's description says it can be used for individual artists, it is a subtype of http://schema.org/PerformingGroup, which does not.

Given it makes distinguishing groups from individuals, the simplest thing would be to expand the range of byArtist to accept http://schema.org/Person as well.

@thadguidry

This comment has been minimized.

Copy link

thadguidry commented Jul 24, 2018

@vholland so we are saying that our Group Types should be considered restricted for use of MORE THAN 1 PERSON ? I'm fine with that restriction.

In some databases, a Music Group could be used for either 1 person or a group. We might want to mention something about our restriction in our MusicGroup and PerformingGroup definitions ?

@vholland

This comment has been minimized.

Copy link
Contributor Author

vholland commented Jul 24, 2018

@thadguidry Yes, that was my thought. Both definitions would need updating.

@danbri

This comment has been minimized.

Copy link
Contributor

danbri commented Jul 25, 2018

SGTM. Can you make a PR (with a line giving docs/releases.html text ideally:)

@vholland

This comment has been minimized.

Copy link
Contributor Author

vholland commented Jul 26, 2018

I will tomorrow. I was being lazy and wanted to make sure there were no shouts of "For the love of all that is good in data modeling, NOOOOO!" before I did any work.

vholland pushed a commit to vholland/schemaorg that referenced this issue Aug 14, 2018

@vholland

This comment has been minimized.

Copy link
Contributor Author

vholland commented Aug 14, 2018

When I said tomorrow, I must have meant in the metaphorical sense. Anyway, see PR #2038

@vholland vholland self-assigned this Oct 19, 2018

danbri added a commit that referenced this issue Dec 11, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.