Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add VisualArtwork vocabulary based on proposal #204

Closed
danbri opened this issue Dec 15, 2014 · 6 comments
Closed

Add VisualArtwork vocabulary based on proposal #204

danbri opened this issue Dec 15, 2014 · 6 comments

Comments

@danbri
Copy link
Contributor

@danbri danbri commented Dec 15, 2014

@danbri
Copy link
Contributor Author

@danbri danbri commented Dec 15, 2014

Needs a bit of work translating examples into other formats

@danbri
Copy link
Contributor Author

@danbri danbri commented Dec 15, 2014

@danbri
Copy link
Contributor Author

@danbri danbri commented Jan 30, 2015

Re-opened as labelled as 'implementing' due to a couple more details (from @tmarshbing):

  • #293 Added URL as an expected type (in addition to Text) to the VisualArtwork properties of "artform", "surface", and "material"
  • The descriptions for depth and height should probably be updated, too. If you look at http://sdo-stantz.appspot.com/VisualArtwork, the descriptions for depth, height, and width are each a little different. I think they should all be, “The {blah} of the item.”
danbri added a commit that referenced this issue Jan 30, 2015
i.e. without mentioning Product, Person or other specific earlier types.
For #204
@danbri
Copy link
Contributor Author

@danbri danbri commented Jan 30, 2015

I've attended to those last 2 details. @tmarshbing @lazaruscorporation how is it looking? are we done?

@lazaruscorporation
Copy link
Contributor

@lazaruscorporation lazaruscorporation commented Jan 30, 2015

@danbri looks good to me!

@tmarshbing
Copy link

@tmarshbing tmarshbing commented Jan 30, 2015

@danbri looks good to me, too. Closing it.

@tmarshbing tmarshbing closed this Jan 30, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.