Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add VisualArtwork vocabulary based on proposal #204

Closed
danbri opened this issue Dec 15, 2014 · 6 comments
Closed

Add VisualArtwork vocabulary based on proposal #204

danbri opened this issue Dec 15, 2014 · 6 comments
Labels
schema.org vocab General top level tag for issues on the vocabulary status:old proposals Proposals that are inactive, abandoned, obsolete or handled another way.
Milestone
sdo-gozer release

Comments

@danbri
Copy link
Contributor

danbri commented Dec 15, 2014

From https://www.w3.org/wiki/WebSchemas/VisualArtwork

https://github.com/danbri/schemaorg/pull/30
@danbri danbri added enhancement schema.org vocab General top level tag for issues on the vocabulary labels Dec 15, 2014
@danbri danbri added this to the sdo-stantz release milestone Dec 15, 2014
@danbri
Copy link
Contributor Author

danbri commented Dec 15, 2014

Needs a bit of work translating examples into other formats

@danbri
Copy link
Contributor Author

danbri commented Dec 15, 2014

Draft for review: http://sdo-stantz.appspot.com/VisualArtwork

@danbri danbri added status:old proposals Proposals that are inactive, abandoned, obsolete or handled another way. type:exact proposal labels Jan 22, 2015
@danbri danbri closed this as completed in 5c47cfc Jan 22, 2015
danbri added a commit that referenced this issue Jan 22, 2015
@danbri
VisualArtwork summary for releases page.
a672583 
Closed #204
@danbri danbri reopened this Jan 30, 2015
@danbri
Copy link
Contributor Author

danbri commented Jan 30, 2015

Re-opened as labelled as 'implementing' due to a couple more details (from @tmarshbing):

danbri added a commit that referenced this issue Jan 30, 2015
@danbri
width/height/depth are now "The {blah} of the item.",
bf79073 
i.e. without mentioning Product, Person or other specific earlier types.
For #204
@danbri
Copy link
Contributor Author

danbri commented Jan 30, 2015

I've attended to those last 2 details. @tmarshbing @lazaruscorporation how is it looking? are we done?

@lazaruscorporation
Copy link
Contributor

@danbri looks good to me!

@tmarshbing
Copy link

@danbri looks good to me, too. Closing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
schema.org vocab General top level tag for issues on the vocabulary status:old proposals Proposals that are inactive, abandoned, obsolete or handled another way.
Projects
None yet
Milestone
sdo-gozer release
Development

No branches or pull requests
3 participants
@danbri @lazaruscorporation @tmarshbing