Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expected value of accessModeSufficient should be ItemList #2040

Closed
mattgarrish opened this issue Aug 17, 2018 · 5 comments
Closed

Expected value of accessModeSufficient should be ItemList #2040

mattgarrish opened this issue Aug 17, 2018 · 5 comments

Comments

@mattgarrish
Copy link
Contributor

As discussed in #1100, accessModeSufficient should expect one or more "ItemList" but it ended up with "Text" in the final release.

Also, as noted in #1100 (comment), the first example should be corrected to use ItemList.

Web publications is looking to implement the property according to the incorrect text value expectation: w3c/wpub#300

/cc @madeleinerothberg @clapierre @avneeshsingh

@clapierre
Copy link

I know that @danbri helped a lot with the AccessModeSufficient when we were working on how to do multiple ItemLists in the various RDFa / JSON implementation examples, I would like to know what happened is it just an example that was incorrectly added and missed? Or if there was something fundamentally wrong with our implementation.

@mattgarrish
Copy link
Contributor Author

I suspect these were just oversights. We were busy working on EPUB's implementation, where we knew we had to convert to strings for the package document, and probably missed these last two tweaks.

Hopefully these are just straight-ahead bug fixes, but welcome the input if not.

@avneeshsingh
Copy link

We were racing to complete this work before combination of IDPF. I think this resulted in such a situation.
I also think that we mainly need to update the examples.

It would be important to have inputs of @madeleinerothberg
She was a key driver of this work.

@madeleinerothberg
Copy link

Yes, where markup allows, AccessModeSufficient should accept one or more ItemLists so that each combination of modes (which represent a single usage style) are bound to each other, and more than one distinct usage style can be documented.

@RichardWallis
Copy link
Contributor

Implemented in PR #2041

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants