Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add membershipPointsEarned property to ProgramMembership #2085

Closed
vholland opened this Issue Oct 19, 2018 · 4 comments

Comments

Projects
None yet
3 participants
@vholland
Copy link
Contributor

commented Oct 19, 2018

Lots of email messages about program memberships describe the points earned. I propose adding a membershipPointsEarned property to ProgramMembership.

The markup might looking something like:

{
  "@context": "http://schema.org/",
  "@type": "ProgramMembership",
  "name": "ACME customer rewards",
  "membershipPointsEarned": {
    "@type": "QuantitativeValue",
    "name": "Starpoints",
    "value": 500
  }
}

The expected type of QuantitativeValue is to allow authors to use their custom name for the point system.

@vholland vholland self-assigned this Oct 19, 2018

@danbri

This comment has been minimized.

Copy link
Contributor

commented Oct 26, 2018

Care to file a PR?

@danbri

This comment has been minimized.

Copy link
Contributor

commented Oct 26, 2018

is the intent that it reports the total on some account, or that it reports an additional number of points corresponding to some transaction being reported in the same message?

@vholland

This comment has been minimized.

Copy link
Contributor Author

commented Oct 29, 2018

The former. A lot of email messages contain reports of the number of points/miles/stars someone has earned.

vholland added a commit to vholland/schemaorg that referenced this issue Nov 8, 2018

danbri added a commit that referenced this issue Dec 11, 2018

@RichardWallis

This comment has been minimized.

Copy link
Contributor

commented Apr 10, 2019

Implemented in release 3.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.