Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decimal separators #2166

Closed
pierrefar opened this issue Mar 7, 2019 · 2 comments

Comments

Projects
None yet
3 participants
@pierrefar
Copy link

commented Mar 7, 2019

Hi

Decimal separators need a another look. For example, in #99, https://schema.org/price says "Use '.' (Unicode 'FULL STOP' (U+002E)) rather than ',' to indicate a decimal point. Avoid using these symbols as a readability separator." But such guidance is not given for other numeric properties such as https://schema.org/ratingValue . I would argue ratingValue is as important as price as they're usually found together.

One approach is to write such guidance when a numeric property is of the type Text, but also add specific instructions on https://schema.org/Number saying to use decimal points as the separator and commas for groups as per current standards (Wikipedia ref).

Thanks.

@danbri danbri self-assigned this Mar 8, 2019

@danbri

This comment has been minimized.

Copy link
Contributor

commented Mar 8, 2019

Hi Pierre! Yes, this makes sense. Number may be a better place for the advice.

@pierrefar

This comment has been minimized.

Copy link
Author

commented Mar 8, 2019

Thanks @danbri . From experience, I know many people use text as that's easier. Being clear there too will help. My 2c.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.