openingHours values are not Duration since it isn't an ISO 8601 Duration #224

Closed
danbri opened this Issue Jan 14, 2015 · 4 comments
@danbri
Contributor
danbri commented Jan 14, 2015

http://schema.org/openingHours

We should specify its weird syntax properly, but for now I'd suggest changing range to "Text".

@danbri danbri self-assigned this Jan 14, 2015
@danbri danbri added this to the sdo-gozer release milestone Jan 21, 2015
@danbri
Contributor
danbri commented Mar 16, 2015

see also #372

@danbri danbri added a commit that closed this issue May 5, 2015
@danbri danbri Changed expected value of openingHours to Text from Duration.
This is because our micro-syntax is not ISO anything, whereas Duration says it is ISO-based.
Fixes #224
edd6640
@danbri danbri closed this in edd6640 May 5, 2015
@danbri
Contributor
danbri commented May 5, 2015

I've made the change for now. We should still specify the weird format but at least we don't claim it is ISO-anything.

@mfhepp
Contributor
mfhepp commented May 5, 2015

I think that for the Q2 release, when extending the opening hours general model, we should consolidate the two properties openingHours and openingHoursSpecification into one, with the range being Text OR OpeningHoursSpecification. But since there is more work to be done in there, I would suggest to defer any further work on this until sdo-gozer is out. The fix you implemented for now is fine from my perspective.

@danbri
Contributor
danbri commented May 5, 2015

Yes - we need to look at the whole package of opening hours and event (repetition?) constructions, in particular considering defaults-and-overides, vacation hours etc. - if you have several opening hour constructs, https://schema.org/closes , how do they combine, ... etc. I suspect scattering the word 'typically' around will be needed. But yes, Q2! A period that we are nearly halfway through.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment