New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openingHours values are not Duration since it isn't an ISO 8601 Duration #224

Closed
danbri opened this Issue Jan 14, 2015 · 4 comments

Comments

@danbri
Contributor

danbri commented Jan 14, 2015

http://schema.org/openingHours

We should specify its weird syntax properly, but for now I'd suggest changing range to "Text".

@danbri

This comment has been minimized.

Show comment
Hide comment
@danbri

danbri Mar 16, 2015

Contributor

see also #372

Contributor

danbri commented Mar 16, 2015

see also #372

@danbri

This comment has been minimized.

Show comment
Hide comment
@danbri

danbri May 5, 2015

Contributor

I've made the change for now. We should still specify the weird format but at least we don't claim it is ISO-anything.

Contributor

danbri commented May 5, 2015

I've made the change for now. We should still specify the weird format but at least we don't claim it is ISO-anything.

@mfhepp

This comment has been minimized.

Show comment
Hide comment
@mfhepp

mfhepp May 5, 2015

Contributor

I think that for the Q2 release, when extending the opening hours general model, we should consolidate the two properties openingHours and openingHoursSpecification into one, with the range being Text OR OpeningHoursSpecification. But since there is more work to be done in there, I would suggest to defer any further work on this until sdo-gozer is out. The fix you implemented for now is fine from my perspective.

Contributor

mfhepp commented May 5, 2015

I think that for the Q2 release, when extending the opening hours general model, we should consolidate the two properties openingHours and openingHoursSpecification into one, with the range being Text OR OpeningHoursSpecification. But since there is more work to be done in there, I would suggest to defer any further work on this until sdo-gozer is out. The fix you implemented for now is fine from my perspective.

@danbri

This comment has been minimized.

Show comment
Hide comment
@danbri

danbri May 5, 2015

Contributor

Yes - we need to look at the whole package of opening hours and event (repetition?) constructions, in particular considering defaults-and-overides, vacation hours etc. - if you have several opening hour constructs, https://schema.org/closes , how do they combine, ... etc. I suspect scattering the word 'typically' around will be needed. But yes, Q2! A period that we are nearly halfway through.

Contributor

danbri commented May 5, 2015

Yes - we need to look at the whole package of opening hours and event (repetition?) constructions, in particular considering defaults-and-overides, vacation hours etc. - if you have several opening hour constructs, https://schema.org/closes , how do they combine, ... etc. I suspect scattering the word 'typically' around will be needed. But yes, Q2! A period that we are nearly halfway through.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment