Skip to content

openingHours values are not Duration since it isn't an ISO 8601 Duration #224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
danbri opened this issue Jan 14, 2015 · 4 comments
Closed

openingHours values are not Duration since it isn't an ISO 8601 Duration #224

danbri opened this issue Jan 14, 2015 · 4 comments
Assignees
@danbri
Labels
guidelines docs examples Work on our supporting materials rather than on schema definitions schema.org vocab General top level tag for issues on the vocabulary type:bug A mistake or malfunction whose remedy should be straightforward technical work
Milestone
sdo-gozer release

Comments

@danbri
Copy link
Contributor

danbri commented Jan 14, 2015

http://schema.org/openingHours

We should specify its weird syntax properly, but for now I'd suggest changing range to "Text".
@danbri danbri added type:bug A mistake or malfunction whose remedy should be straightforward technical work guidelines docs examples Work on our supporting materials rather than on schema definitions easy ones labels Jan 14, 2015
@danbri danbri self-assigned this Jan 14, 2015
@danbri danbri added this to the sdo-gozer release milestone Jan 21, 2015
@danbri
Copy link
Contributor Author

danbri commented Mar 16, 2015

see also #372

@danbri danbri mentioned this issue Mar 16, 2015
Closed
@danbri danbri added the schema.org vocab General top level tag for issues on the vocabulary label May 5, 2015
@danbri danbri closed this as completed in edd6640 May 5, 2015
@danbri
Copy link
Contributor Author

danbri commented May 5, 2015

I've made the change for now. We should still specify the weird format but at least we don't claim it is ISO-anything.

@mfhepp
Copy link
Contributor

mfhepp commented May 5, 2015

I think that for the Q2 release, when extending the opening hours general model, we should consolidate the two properties openingHours and openingHoursSpecification into one, with the range being Text OR OpeningHoursSpecification. But since there is more work to be done in there, I would suggest to defer any further work on this until sdo-gozer is out. The fix you implemented for now is fine from my perspective.

@danbri
Copy link
Contributor Author

danbri commented May 5, 2015

Yes - we need to look at the whole package of opening hours and event (repetition?) constructions, in particular considering defaults-and-overides, vacation hours etc. - if you have several opening hour constructs, https://schema.org/closes , how do they combine, ... etc. I suspect scattering the word 'typically' around will be needed. But yes, Q2! A period that we are nearly halfway through.

@danbri danbri mentioned this issue Jun 20, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danbri danbri

Labels
guidelines docs examples Work on our supporting materials rather than on schema definitions schema.org vocab General top level tag for issues on the vocabulary type:bug A mistake or malfunction whose remedy should be straightforward technical work
Projects
None yet
Milestone
sdo-gozer release
Development

No branches or pull requests
2 participants
@danbri @mfhepp