Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend the audio property's range to include MusicRecording #2420

Closed
vholland opened this issue Dec 9, 2019 · 2 comments
Closed

Extend the audio property's range to include MusicRecording #2420

vholland opened this issue Dec 9, 2019 · 2 comments
Assignees
Labels
schema.org vocab

Comments

@vholland
Copy link
Contributor

@vholland vholland commented Dec 9, 2019

The audio property currently expects the value to either be an AudioObject or a Clip, but there are times when a work may embed a song for which there isn't a separate AudioObject to link to.

I propose adding MusicRecording to the range so authors can specify the song without having to have a separate, downloadable file.

@vholland vholland self-assigned this Dec 9, 2019
@vholland vholland added schema.org vocab type:exact proposal labels Dec 9, 2019
vholland added a commit to vholland/schemaorg that referenced this issue Dec 10, 2019
@vholland
Copy link
Contributor Author

@vholland vholland commented Dec 10, 2019

Implemented as PR #2424

danbri pushed a commit that referenced this issue Jan 2, 2020
* Issue #2341: Added SportsTeam to the domain for gender.

* Remove file added to wrong branch.

* Issue #2420: Added MusicRecording to the range for audio.

* Added to the range rather than the domain.
@vholland
Copy link
Contributor Author

@vholland vholland commented May 28, 2020

Included in schema.org 6.0

@vholland vholland closed this May 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
schema.org vocab
Projects
None yet
Development

No branches or pull requests

1 participant