Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PreOrder ItemAvailability wording needlessly excludes non-deliverable items #2433

Closed
danbri opened this issue Jan 2, 2020 · 3 comments
Closed

PreOrder ItemAvailability wording needlessly excludes non-deliverable items #2433

danbri opened this issue Jan 2, 2020 · 3 comments

Comments

@danbri
Copy link
Contributor

@danbri danbri commented Jan 2, 2020

Second half of "Indicates that the item is available for pre-order, but will be delivered when generally available." is not needed for concept of "pre-order" and excludes services, collectables, etc.
@danbri
Copy link
Contributor Author

@danbri danbri commented Jan 2, 2020

00ab7d9

Noted in docs/releases.html

@SignpostMarv
Copy link

@SignpostMarv SignpostMarv commented Jan 10, 2020

would it not be preferable to replace "delivered" with "fulfilled" ?

@RichardWallis
Copy link
Contributor

@RichardWallis RichardWallis commented Jul 1, 2020

Implemented in commit 00ab7d9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@danbri @SignpostMarv @RichardWallis