Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add subtype of /Collection for collections of products (/ProductCollection) #2605

Closed
danbri opened this issue Jun 19, 2020 · 8 comments
Closed
Assignees
Labels
no-issue-activity Discuss has gone quiet. Auto-tagging to encourage people to re-engage with the issue (or close it!).

Comments

@danbri
Copy link
Contributor

danbri commented Jun 19, 2020

Add a type indicating a group of products that are offered as a single collection - e.g. camera plus a lens.

@danbri danbri self-assigned this Jun 19, 2020
@jvandriel
Copy link

jvandriel commented Jun 19, 2020

For this I'd normally publish something like this:

{
  "@type":"Product",
  "name":"Camera plus a lens",
  "offers":
  {
    "@type":"Offer",
    "price":"xxx",
    "priceCurrency":"USD",
    "itemOffered":
    [
      {
        "@type":"Product",
        "name":"product 1"
      },{
        "@type":"Product",
        "name":"product 2"
      }
    ]
  }
}

Would Product (as mentioned in the example) become ProductCollection with this proposal?

@mfhepp
Copy link
Contributor

mfhepp commented Jun 20, 2020

@jvandriel
Copy link

jvandriel commented Jun 20, 2020

Thanks for pointing that out @mfhepp (I should have known that without you having to point it out). I guess the example should have been like this instead:

{
  "@type":"Product",
  "name":"Camera plus a lens",
  "offers":
  {
    "@type":"Offer",
    "businessFunction":"http://purl.org/goodrelations/v1#Sell",
    "price":"xxx",
    "priceCurrency":"USD",
    "includesObject":
    [
      {
        "@type":"TypeAndQuantityNode",
        "typeOfGood":
        {
          "@type":"Product",
          "name":"Camera"
        },
        "amountOfThisGood":1
      },{
        "@type":"TypeAndQuantityNode",
        "typeOfGood":
        {
          "@type":"Product",
          "name":"Lens"
        },
        "amountOfThisGood":1
      }
    ]
  }
}

@mfhepp
Copy link
Contributor

mfhepp commented Jun 20, 2020

@danbri
Copy link
Contributor Author

danbri commented Jun 24, 2020

How about we allow 'includesObject' on ProductCollection, and then re-use that structure for the complex case; there are cases when the collection is not primarily an artifact of a (transient etc.) offer but has some longer term coherence in itself. For simpler cases we might want to skip the TypeAndQuantityNode and just point to the Product?

@jvandriel
Copy link

jvandriel commented Jun 25, 2020

"For simpler cases we might want to skip the TypeAndQuantityNode and just point to the Product?"

Sounds good to me @danbri. Reason I asked whether your suggestion covers products as per the example is because per my experience a lot of ecommerce systems don't have any option (by default) to define 'composite products'. Meaning that providing includesObject information will be hard (if not impossible) for many out there, and thus having a ProductCollection type might be a good way to be able to differentiate such products from 'normal' products when further data is missing.

@github-actions
Copy link

github-actions bot commented Aug 25, 2020

This issue is being tagged as Stale due to inactivity.

@github-actions github-actions bot added the no-issue-activity Discuss has gone quiet. Auto-tagging to encourage people to re-engage with the issue (or close it!). label Aug 25, 2020
@danbri
Copy link
Contributor Author

danbri commented Aug 25, 2020

@danbri danbri closed this as completed Aug 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-issue-activity Discuss has gone quiet. Auto-tagging to encourage people to re-engage with the issue (or close it!).
Projects
None yet
Development

No branches or pull requests

3 participants