Orders schema updates #266

Closed
danbri opened this Issue Jan 22, 2015 · 7 comments
@vholland vholland self-assigned this Jan 22, 2015
@danbri danbri added this to the 2015 Q1 milestone Jan 29, 2015
@vholland vholland added a commit to vholland/schemaorg that referenced this issue Feb 5, 2015
@vholland vholland Issue #266: Merged in proposed additions with minor name changes to a…
…void conflicts.
5fc5760
@tmarshbing

For orderItemId, should we rename that to orderItemNumber to be consistent with http://schema.org/orderNumber?

How can you tell the product ordered for a given OrderItem? I see the property from Order -> orderedItem -> OrderItem, but I think we should also add OrderItem to the domain of orderedItem. Which then introduces the possibility of a loop. If we're worried about the loop, we could always separate out orderedItem (range Product) from a new property orderLine (range OrderItem, which could then be renamed to OrderLine).

@realworldobject

Or perhaps:

schema:id
a rdf:Property;
schema:domainIncludes schema:Thing;
schema:rangeIncludes schema:Text .

On Mar 10, 2015, at 7:45 PM, tmarshbing <notifications@github.commailto:notifications@github.com> wrote:

For orderItemId, should we rename that to orderItemNumber to be consistent with http://schema.org/orderNumber?

How can you tell the product ordered for a given OrderItem? I see the property from Order -> orderedItem -> OrderItem, but I think we should also add OrderItem to the domain of orderedItem. Which then introduces the possibility of a loop. If we're worried about the loop, we could always separate out orderedItem (range Product) from a new property orderLine (range OrderItem, which could then be renamed to OrderLine).

Reply to this email directly or view it on GitHubhttps://github.com/schemaorg/schemaorg/issues/266#issuecomment-78173190.

@vholland
Contributor

I updated the pull request to add orderedItem to the list of properties. This allows one to link directly from the OrderItem to the Product.

I also added an example of this.

@tmarshbing

Looks good!

@chaals
Contributor
chaals commented Mar 20, 2015

Looks OK to me.

@vholland vholland modified the milestone: sdo-gozer release, 2015 Q1 Apr 2, 2015
@vholland
Contributor
vholland commented Apr 8, 2015

Merged into sdo-gozer.

@vholland vholland closed this Apr 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment