Skip to content

/ schemaorg

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TradeAction should allow a priceSpecification as well as price #305

Closed
vholland opened this issue Jan 29, 2015 · 2 comments
Closed

TradeAction should allow a priceSpecification as well as price #305

vholland opened this issue Jan 29, 2015 · 2 comments
Assignees
@vholland
Labels
schema.org vocab
Milestone
sdo-stantz release

Comments

@vholland
Copy link
Contributor

@vholland vholland commented Jan 29, 2015

TradeAction's price property only takes text or number. It should also take a PriceSpecification for more specific price models.
vholland added a commit to vholland/schemaorg that referenced this issue Jan 29, 2015
@vholland
Issue schemaorg#305: Added TradeAction to the domain for priceSpecifi…
2da6367 
…cation.
@vholland
Copy link
Contributor Author

@vholland vholland commented Jan 29, 2015

I just remembered that price is a property of PriceSpecification. To avoid a loop, the change should be to the "priceSpecification" property.
@danbri danbri added this to the sdo-stantz release milestone Jan 30, 2015
danbri added a commit that referenced this issue Jan 30, 2015
@danbri
Merge pull request #307 from vholland/trade-action
9287cb1 
Issue #305: Added TradeAction to the domain for priceSpecification.
@danbri danbri changed the title The price property on TradeAction should also take a PriceSpecification TradeAction should allow a priceSpecification as well as price Jan 30, 2015
@danbri
Copy link
Contributor

@danbri danbri commented Jan 30, 2015

Done: http://sdo-stantz.appspot.com/TradeAction
@danbri danbri closed this Jan 30, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vholland vholland

Labels
schema.org vocab
Projects
None yet
Milestone
sdo-stantz release
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@danbri @vholland
You can’t perform that action at this time.