New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TradeAction should allow a priceSpecification as well as price #305

Closed
vholland opened this Issue Jan 29, 2015 · 2 comments

Comments

Projects
None yet
2 participants
@vholland
Contributor

vholland commented Jan 29, 2015

TradeAction's price property only takes text or number. It should also take a PriceSpecification for more specific price models.

vholland added a commit to vholland/schemaorg that referenced this issue Jan 29, 2015

@vholland

This comment has been minimized.

Show comment
Hide comment
@vholland

vholland Jan 29, 2015

Contributor

I just remembered that price is a property of PriceSpecification. To avoid a loop, the change should be to the "priceSpecification" property.

Contributor

vholland commented Jan 29, 2015

I just remembered that price is a property of PriceSpecification. To avoid a loop, the change should be to the "priceSpecification" property.

@danbri danbri added this to the sdo-stantz release milestone Jan 30, 2015

danbri added a commit that referenced this issue Jan 30, 2015

Merge pull request #307 from vholland/trade-action
Issue #305: Added TradeAction to the domain for priceSpecification.

@danbri danbri changed the title from The price property on TradeAction should also take a PriceSpecification to TradeAction should allow a priceSpecification as well as price Jan 30, 2015

@danbri

This comment has been minimized.

Show comment
Hide comment
Contributor

danbri commented Jan 30, 2015

@danbri danbri closed this Jan 30, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment