Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

accessibilityHazard content #334

Closed
philwareham opened this issue Feb 12, 2015 · 6 comments
Closed

accessibilityHazard content #334

philwareham opened this issue Feb 12, 2015 · 6 comments
Assignees
Labels
type:bug A mistake or malfunction whose remedy should be straightforward technical work

Comments

@philwareham
Copy link

philwareham commented Feb 12, 2015

The Schema.org site lists the following example content for accessibilityHazard...

<meta itemprop="accessibilityHazard" content="noFlashing"/>
<meta itemprop="accessibilityHazard" content="noMotionSimulation"/>
<meta itemprop="accessibilityHazard" content="noSound"/>

But the linked reference page WebSchemas wiki lists possible values lists them as follows...

<meta itemprop="accessibilityHazard" content="noFlashingHazard"/>
<meta itemprop="accessibilityHazard" content="noMotionSimulationHazard"/>
<meta itemprop="accessibilityHazard" content="noSoundHazard"/>

Which is the correct implementation? Thanks!

@danbri
Copy link
Contributor

danbri commented Feb 12, 2015

@chaals can you take a look?

@danbri danbri added status:work expected We are likely to, or would like to, or probably should try, ... to do something in this area. type:question labels Feb 12, 2015
@chaals
Copy link
Contributor

chaals commented Jun 1, 2015

It's listed "implemented on 10-100 pages". I suggest we change the schema.org content.

@chaals
Copy link
Contributor

chaals commented Jun 30, 2015

Hopefully I'll make a pull request to do this.

Having hazard in the name seems better - not all flashing is a flashing hazard…

@philwareham
Copy link
Author

philwareham commented Jun 30, 2015

Makes sense to me, thanks!

chaals pushed a commit to chaals/schemaorg that referenced this issue Jun 30, 2015
Added the keyword as per the information out there. Closes schemaorg#334
@chaals chaals assigned danbri and unassigned chaals Jun 30, 2015
@chaals
Copy link
Contributor

chaals commented Jun 30, 2015

Worky for you?

@chaals chaals added type:bug A mistake or malfunction whose remedy should be straightforward technical work status:needs review and removed status:work expected We are likely to, or would like to, or probably should try, ... to do something in this area. labels Jun 30, 2015
@danbri
Copy link
Contributor

danbri commented Jun 30, 2015

Alright, this is merged in and queued for the next release which I'd like to see out in a modest number of days...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug A mistake or malfunction whose remedy should be straightforward technical work
Projects
None yet
Development

No branches or pull requests

3 participants