New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VideoGameSeries example on VideoGame uses gameLocation #335

Closed
Aaranged opened this Issue Feb 12, 2015 · 8 comments

Comments

Projects
None yet
5 participants
@Aaranged

Aaranged commented Feb 12, 2015

On:
http://schema.org/VideoGame

The last example (JSON-LD) is for VideoGameSeries, and employs the property "gameLocation".

<script type="application/ld+json">
{
"@context": "http://schema.org",
"@type": "VideoGameSeries",
"name":"Mass Effect",
"genre":["ARPG", "third-person shooter"],
"author":"BioWare",
"character":{
"@type":"Person",
"name":"Shepard",
"birthDate":"2154-04-11"
},
"gameLocation":
{"@type":"Place",
"name":"Citadel",
[...]

However, while "gameLocation" is a valid property for VideoGame, it is not a valid property for VideoGameSeries.

@thadguidry

This comment has been minimized.

Show comment
Hide comment
@thadguidry

thadguidry Feb 13, 2015

Would you rather it be called gameSeriesLocation ?

thadguidry commented Feb 13, 2015

Would you rather it be called gameSeriesLocation ?

@Aaranged

This comment has been minimized.

Show comment
Hide comment
@Aaranged

Aaranged Feb 13, 2015

@thadguidry "gameLocation" is just fine. The bug I'm pointing out isn't that the label is a bad one, but that the example for VideoGameSeries uses a property - gameLocation - which isn't a property listed under VideoGameSeries (it's a little confusing because the VideoGameSeries example is actually found on the VideoGame page).

Either removing the gameLocation property declaration from the example or adding gameLocation as a property under VideoGameSeries will clean up the example. FWIW I favor the latter, as indeed a video game series can have a location.

Aaranged commented Feb 13, 2015

@thadguidry "gameLocation" is just fine. The bug I'm pointing out isn't that the label is a bad one, but that the example for VideoGameSeries uses a property - gameLocation - which isn't a property listed under VideoGameSeries (it's a little confusing because the VideoGameSeries example is actually found on the VideoGame page).

Either removing the gameLocation property declaration from the example or adding gameLocation as a property under VideoGameSeries will clean up the example. FWIW I favor the latter, as indeed a video game series can have a location.

@danbri

This comment has been minimized.

Show comment
Hide comment
@danbri

danbri Feb 16, 2015

Contributor

Thanks. It seems appropriate to allow this, one way or another.

Contributor

danbri commented Feb 16, 2015

Thanks. It seems appropriate to allow this, one way or another.

@danbri danbri added this to the sdo-gozer release milestone Feb 16, 2015

@danbri danbri self-assigned this Feb 16, 2015

@vholland

This comment has been minimized.

Show comment
Hide comment
@vholland

vholland Mar 16, 2015

Contributor

+1 It seems more useful to add gameLocation to VideoGameSeries rather than modifying the example.

Contributor

vholland commented Mar 16, 2015

+1 It seems more useful to add gameLocation to VideoGameSeries rather than modifying the example.

@danbri

This comment has been minimized.

Show comment
Hide comment
@danbri

danbri Mar 16, 2015

Contributor

I'll tentatively add it to the sdo-gozer build, but let's get some more +1s here before confirming. @tilid ? @tmarshbing @pmika ?

Contributor

danbri commented Mar 16, 2015

I'll tentatively add it to the sdo-gozer build, but let's get some more +1s here before confirming. @tilid ? @tmarshbing @pmika ?

@thadguidry

This comment has been minimized.

Show comment
Hide comment
@thadguidry

thadguidry Mar 16, 2015

thadguidry commented Mar 16, 2015

@tmarshbing

This comment has been minimized.

Show comment
Hide comment
@tmarshbing

tmarshbing Mar 17, 2015

+1 to add gameLocation to VideoGameSeries.

tmarshbing commented Mar 17, 2015

+1 to add gameLocation to VideoGameSeries.

@danbri danbri referenced this issue Apr 9, 2015

Closed

Meta bug for sdo-gozer release - vocab issues #418

19 of 36 tasks complete
@danbri

This comment has been minimized.

Show comment
Hide comment
@danbri

danbri Apr 16, 2015

Contributor

Hearing no complaints, let's close out the issue.

Contributor

danbri commented Apr 16, 2015

Hearing no complaints, let's close out the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment