Skip to content

TVSeries and TVEpisode have actors and directors, but TVSeason does not #336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
vickitardif opened this issue Feb 13, 2015 · 5 comments
Closed

TVSeries and TVEpisode have actors and directors, but TVSeason does not #336

vickitardif opened this issue Feb 13, 2015 · 5 comments
Assignees
@vickitardif
Milestone
sdo-gozer release

Comments

@vickitardif
Copy link
Contributor

The properties "actor" and "director" exist on TVSeries and TVEpisode. We should add TVSeason to the domain to round out the possibilities.
vickitardif added a commit to vickitardif/schemaorg that referenced this issue Feb 13, 2015
@vickitardif
Issue schemaorg#336: Added Season to the domain for schema.org/actor …
af3d080 
…and schema.org/director.
@vickitardif
Copy link
Contributor Author

See pull request#337: https://github.com/schemaorg/schemaorg/pull/337/files

@vickitardif vickitardif self-assigned this Feb 13, 2015
@danbri
Copy link
Contributor

danbri commented Mar 5, 2015

I suggest we add those to http://schema.org/Season instead of to TVSeason. This will then apply to
RadioSeason and TVSeason, as well as to any others that emerge.

Series is a bit different as it covers more variety, but we could add RadioSeries too while we're at it.

Looking at adding actor/director to each of the Series subtypes individually, my suggestions are:

  • BookSeries [no],
  • MovieSeries [yes],
  • Periodical [no],
  • RadioSeries [yes],
  • TVSeries [already],
  • VideoGameSeries [yes]

@vickitardif
Copy link
Contributor Author

+1. I'll add it to schema.org/Season.

@vickitardif
Copy link
Contributor Author

It turns out I had already figured this out and put the property on schema.org/Season.

danbri added a commit that referenced this issue Mar 20, 2015
@danbri
Merge pull request #337 from vholland/tv-season-quick-fix
48c4695 
Issue #336: Added Season to the domain for schema.org/actor and schema.org/director.
@vickitardif
Copy link
Contributor Author

Merged into sdo-gozer.

@vickitardif vickitardif added this to the sdo-gozer release milestone Apr 10, 2015
@danbri danbri mentioned this issue Jun 20, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vickitardif vickitardif

Labels
None yet
Projects
None yet
Milestone
sdo-gozer release
Development

No branches or pull requests
2 participants
@danbri @vickitardif