New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TVSeries and TVEpisode have actors and directors, but TVSeason does not #336

Closed
vholland opened this Issue Feb 13, 2015 · 5 comments

Comments

Projects
None yet
2 participants
@vholland
Contributor

vholland commented Feb 13, 2015

The properties "actor" and "director" exist on TVSeries and TVEpisode. We should add TVSeason to the domain to round out the possibilities.

vholland added a commit to vholland/schemaorg that referenced this issue Feb 13, 2015

@vholland

This comment has been minimized.

Show comment
Hide comment
Contributor

vholland commented Feb 13, 2015

@vholland vholland self-assigned this Feb 13, 2015

@danbri

This comment has been minimized.

Show comment
Hide comment
@danbri

danbri Mar 5, 2015

Contributor

I suggest we add those to http://schema.org/Season instead of to TVSeason. This will then apply to
RadioSeason and TVSeason, as well as to any others that emerge.

Series is a bit different as it covers more variety, but we could add RadioSeries too while we're at it.

Looking at adding actor/director to each of the Series subtypes individually, my suggestions are:

  • BookSeries [no],
  • MovieSeries [yes],
  • Periodical [no],
  • RadioSeries [yes],
  • TVSeries [already],
  • VideoGameSeries [yes]
Contributor

danbri commented Mar 5, 2015

I suggest we add those to http://schema.org/Season instead of to TVSeason. This will then apply to
RadioSeason and TVSeason, as well as to any others that emerge.

Series is a bit different as it covers more variety, but we could add RadioSeries too while we're at it.

Looking at adding actor/director to each of the Series subtypes individually, my suggestions are:

  • BookSeries [no],
  • MovieSeries [yes],
  • Periodical [no],
  • RadioSeries [yes],
  • TVSeries [already],
  • VideoGameSeries [yes]
@vholland

This comment has been minimized.

Show comment
Hide comment
@vholland

vholland Mar 5, 2015

Contributor

+1. I'll add it to schema.org/Season.

Contributor

vholland commented Mar 5, 2015

+1. I'll add it to schema.org/Season.

@vholland

This comment has been minimized.

Show comment
Hide comment
@vholland

vholland Mar 18, 2015

Contributor

It turns out I had already figured this out and put the property on schema.org/Season.

Contributor

vholland commented Mar 18, 2015

It turns out I had already figured this out and put the property on schema.org/Season.

danbri added a commit that referenced this issue Mar 20, 2015

Merge pull request #337 from vholland/tv-season-quick-fix
Issue #336: Added Season to the domain for schema.org/actor and schema.org/director.
@vholland

This comment has been minimized.

Show comment
Hide comment
@vholland

vholland Apr 8, 2015

Contributor

Merged into sdo-gozer.

Contributor

vholland commented Apr 8, 2015

Merged into sdo-gozer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment