Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Description of sampleType #343

Closed
unor opened this issue Feb 17, 2015 · 1 comment
Closed

Description of sampleType #343

unor opened this issue Feb 17, 2015 · 1 comment
Assignees
@vickitardif
Labels
schema.org vocab General top level tag for issues on the vocabulary

Comments

@unor
Copy link
Contributor

unor commented Feb 17, 2015

The description of the sampleType property currently is:

Full (compile ready) solution, code snippet, inline code, scripts, template.

As far as I understand it, it lists possible example values instead of describing the purpose of the property.

I think it should start with a description instead, followed by these example values.

(On a side note, I wonder why it’s called "sampleType" instead of something like "codeType", as Code is not only for samples of code.)
@vickitardif vickitardif self-assigned this May 14, 2015
@stuartrobinson stuartrobinson mentioned this issue May 19, 2015
Merged
danbri added a commit that referenced this issue May 20, 2015
@danbri
Merge pull request #513 from stuartrobinson/stuart/issue/343
c1e5058 
Updated description of properties sampleType and codeSampleType. Fixes issue #343.
danbri added a commit that referenced this issue May 20, 2015
@danbri
Noted fix to #343. Thanks @stuartrobinson, @unor!
750dbf6
@danbri
Copy link
Contributor

danbri commented May 27, 2015

Fixed, thanks!

@danbri danbri closed this as completed May 27, 2015
@danbri danbri added the schema.org vocab General top level tag for issues on the vocabulary label May 27, 2015
danbri added a commit that referenced this issue Jun 17, 2016
@danbri
Fixed reversions to codeSampleType (and superseded sampleType) defini…
c66a466 
…tions.

The 3.0 release had this reverted. See #1203

See also http://schema.org/docs/releases.html#g343 #343
@danbri danbri mentioned this issue Jun 21, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vickitardif vickitardif

Labels
schema.org vocab General top level tag for issues on the vocabulary
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@danbri @vickitardif @unor