New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebPage example does not use WebPage #382

Open
Aaranged opened this Issue Mar 16, 2015 · 2 comments

Comments

Projects
None yet
4 participants
@Aaranged

Aaranged commented Mar 16, 2015

On:
http://schema.org/WebPage

We find this example (quoted is the "Without markup" tab)

How to Tie a Reef Knot
by John Doe
This article has been tweeted 1203 times and contains 78 user comments.

However, the class schema.org/WebPage is not employed in any of the examples: not in the microdata, RDFa or JSON-LD tabs. The only class employed is schema.org/Article (and the only relation that Article has to WebPage is that they're both types of CreativeWork).

Accordingly, this example should either be changed to use WebPage, or removed. The only likely consequence of using an "example" for WebPage that does not include WebPage is to confuse users that look at the example.

@jvandriel

This comment has been minimized.

Show comment
Hide comment
@jvandriel

jvandriel Mar 17, 2015

Since @Aaranged started an example wishlist I'd like to add something to that.

In almost every use case I've encountered I've seen folks use the 'mainContentOfPage' property as if it's a 'mainEntity' property, meaning I've seen it be used in combination with types like Article, BlogPosting, Product, etc. but almost never have I seen it be used in combination with WebPageElement or it's subClasses.

Something I think finds it's origin in [a] lack of proper examples, and [b] lack of a 'mainEntity' property. So If a proper example get's written could please make sure it also contains an example of how one is supposed to use the 'mainContentOfPage' property?

jvandriel commented Mar 17, 2015

Since @Aaranged started an example wishlist I'd like to add something to that.

In almost every use case I've encountered I've seen folks use the 'mainContentOfPage' property as if it's a 'mainEntity' property, meaning I've seen it be used in combination with types like Article, BlogPosting, Product, etc. but almost never have I seen it be used in combination with WebPageElement or it's subClasses.

Something I think finds it's origin in [a] lack of proper examples, and [b] lack of a 'mainEntity' property. So If a proper example get's written could please make sure it also contains an example of how one is supposed to use the 'mainContentOfPage' property?

vholland added a commit that referenced this issue May 20, 2015

Merge pull request #512 from stuartrobinson/stuart/issue/382
Don't associated WebPage with Article example. Fix for issue #382.
@vholland

This comment has been minimized.

Show comment
Hide comment
@vholland

vholland May 20, 2015

Contributor

Can we close this and take up mainContentOfPage and WebPageElement in another issue?

Contributor

vholland commented May 20, 2015

Can we close this and take up mainContentOfPage and WebPageElement in another issue?

RichardWallis added a commit that referenced this issue Jul 17, 2015

Fixes to Book examples - issue #552
Removed examples that don't reference WebPage from WebPage - issue #382
Added Report / genre example - issue #374
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment