-
Notifications
You must be signed in to change notification settings - Fork 851
numberOfItems clarification #439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Thanks. We also managed to typo "full" for "fully". Suggested resolution:
|
Minor nit: e.g. should always have a comma after it: proposed: "The number of items in an ItemList. Note that some descriptions might not fully describe all items in a list (e.g., multi-page pagination); in such cases, the numberOfItems would be for the entire list." |
+1 @danbri (clarifies it) and +1 to @halindrome (as we should use US English, where a comma should follow)
Pull request for the proposed version: #443 |
Ok, I'll let's consider this resolved and leave it open for implementation. Thanks all :) |
The current description of
numberOfItems
:I think the second sentence could be more clear; a Stack Overflow user is also not sure about it.
It is my understanding that
numberOfItems
should always specify the total number, even for paginated or teaser lists. Correct?Example: The homepage contains a sidebar, "My favorite movies", teasing only 2 of 6 movies, with a link to the page with the full list. In both cases,
numberOfItems
should be6
.I guess it would be different if the
ItemList
items had different URLs, as we’d have multiple lists then, not the same represented differently. Correct?The text was updated successfully, but these errors were encountered: