numberOfItems clarification #439

Closed
unor opened this Issue Apr 21, 2015 · 4 comments

Projects

None yet

3 participants

@unor
Contributor
unor commented Apr 21, 2015

The current description of numberOfItems:

The number of items in an ItemList. Note that some descriptions might not full describe all items in a list (e.g. multi-page pagination).

I think the second sentence could be more clear; a Stack Overflow user is also not sure about it.

It is my understanding that numberOfItems should always specify the total number, even for paginated or teaser lists. Correct?

Example: The homepage contains a sidebar, "My favorite movies", teasing only 2 of 6 movies, with a link to the page with the full list. In both cases, numberOfItems should be 6.

  <!-- http://example.com/ -->

  <div itemscope itemtype="http://schema.org/ItemList">
      <meta itemprop="numberOfItems" content="6"/>
      <p itemprop="itemListElement">…</p>
      <p itemprop="itemListElement">…</p>
      <a itemprop="url" href="/favorite-movies">Full list</a>
  </div>

  <!-- http://example.com/favorite-movies -->

  <div itemscope itemtype="http://schema.org/ItemList">
      <link itemprop="url" href="/favorite-movies"/>
      <meta itemprop="numberOfItems" content="6"/>
      <p itemprop="itemListElement">…</p>
      <p itemprop="itemListElement">…</p>
      <p itemprop="itemListElement">…</p>
      <p itemprop="itemListElement">…</p>
      <p itemprop="itemListElement">…</p>
      <p itemprop="itemListElement">…</p>
  </div>

I guess it would be different if the ItemList items had different URLs, as we’d have multiple lists then, not the same represented differently. Correct?

@danbri danbri added this to the sdo-gozer release milestone Apr 21, 2015
@danbri danbri self-assigned this Apr 21, 2015
@danbri
Contributor
danbri commented Apr 22, 2015

Thanks. We also managed to typo "full" for "fully".

Suggested resolution:

  • current: "The number of items in an ItemList. Note that some descriptions might not full describe all items in a list (e.g. multi-page pagination)."
  • proposed: "The number of items in an ItemList. Note that some descriptions might not fully describe all items in a list (e.g. multi-page pagination); in such cases, the numberOfItems would be for the entire list."
@halindrome

Minor nit: e.g. should always have a comma after it:

proposed: "The number of items in an ItemList. Note that some descriptions might not fully describe all items in a list (e.g., multi-page pagination); in such cases, the numberOfItems would be for the entire list."

@unor
Contributor
unor commented Apr 22, 2015

+1 @danbri (clarifies it) and +1 to @halindrome (as we should use US English, where a comma should follow)

The number of items in an ItemList. Note that some descriptions might not fully describe all items in a list (e.g., multi-page pagination); in such cases, the numberOfItems would be for the entire list.

Pull request for the proposed version: #443

@danbri
Contributor
danbri commented Apr 22, 2015

Ok, I'll let's consider this resolved and leave it open for implementation. Thanks all :)

@danbri danbri added a commit that referenced this issue Apr 24, 2015
@danbri danbri Noted #439 b5738ab
@danbri danbri closed this Apr 24, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment