Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

numberOfItems clarification #439

Closed
unor opened this issue Apr 21, 2015 · 4 comments
Closed

numberOfItems clarification #439

unor opened this issue Apr 21, 2015 · 4 comments
Assignees

Comments

@unor
Copy link
Contributor

@unor unor commented Apr 21, 2015

The current description of numberOfItems:

The number of items in an ItemList. Note that some descriptions might not full describe all items in a list (e.g. multi-page pagination).

I think the second sentence could be more clear; a Stack Overflow user is also not sure about it.

It is my understanding that numberOfItems should always specify the total number, even for paginated or teaser lists. Correct?

Example: The homepage contains a sidebar, "My favorite movies", teasing only 2 of 6 movies, with a link to the page with the full list. In both cases, numberOfItems should be 6.

  <!-- http://example.com/ -->

  <div itemscope itemtype="http://schema.org/ItemList">
      <meta itemprop="numberOfItems" content="6"/>
      <p itemprop="itemListElement"></p>
      <p itemprop="itemListElement"></p>
      <a itemprop="url" href="/favorite-movies">Full list</a>
  </div>

  <!-- http://example.com/favorite-movies -->

  <div itemscope itemtype="http://schema.org/ItemList">
      <link itemprop="url" href="/favorite-movies"/>
      <meta itemprop="numberOfItems" content="6"/>
      <p itemprop="itemListElement"></p>
      <p itemprop="itemListElement"></p>
      <p itemprop="itemListElement"></p>
      <p itemprop="itemListElement"></p>
      <p itemprop="itemListElement"></p>
      <p itemprop="itemListElement"></p>
  </div>

I guess it would be different if the ItemList items had different URLs, as we’d have multiple lists then, not the same represented differently. Correct?

@danbri danbri added this to the sdo-gozer release milestone Apr 21, 2015
@danbri danbri self-assigned this Apr 21, 2015
@danbri
Copy link
Contributor

@danbri danbri commented Apr 22, 2015

Thanks. We also managed to typo "full" for "fully".

Suggested resolution:

  • current: "The number of items in an ItemList. Note that some descriptions might not full describe all items in a list (e.g. multi-page pagination)."
  • proposed: "The number of items in an ItemList. Note that some descriptions might not fully describe all items in a list (e.g. multi-page pagination); in such cases, the numberOfItems would be for the entire list."
@halindrome
Copy link

@halindrome halindrome commented Apr 22, 2015

Minor nit: e.g. should always have a comma after it:

proposed: "The number of items in an ItemList. Note that some descriptions might not fully describe all items in a list (e.g., multi-page pagination); in such cases, the numberOfItems would be for the entire list."

@unor
Copy link
Contributor Author

@unor unor commented Apr 22, 2015

+1 @danbri (clarifies it) and +1 to @halindrome (as we should use US English, where a comma should follow)

The number of items in an ItemList. Note that some descriptions might not fully describe all items in a list (e.g., multi-page pagination); in such cases, the numberOfItems would be for the entire list.

Pull request for the proposed version: #443

@danbri
Copy link
Contributor

@danbri danbri commented Apr 22, 2015

Ok, I'll let's consider this resolved and leave it open for implementation. Thanks all :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.