-
Notifications
You must be signed in to change notification settings - Fork 825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
exampleOfWork and workExample lack JSON-LD example #471
Comments
Thanks. Not sure what happened there. @dbs @Dataliberate any idea? Here's a quick first pass.
|
I think we also ought to say ""The Fellowship of the Ring" instead of "The Fellowship of the Ring_s_" |
The RDFa didn't parse well so I started again from the Microdata:
|
@Dataliberate - did we both just do the same thing in parallel? see my version above... |
I did the RDFa and the JSON for the full Microdata. Just spotted a typo in the RDFa I posted - the '&' on line 7 needs to be escaped as |
@danbri To address "what happened?", I think the development of the original examples predated the general availability of JSON-LD examples for most types. Note that the JSON-LD example that @Dataliberate provided more faithfully matches the source microdata / RDFa examples. Pull request forthcoming accordingly. @Dataliberate Can you define what you mean by "the RDFa didn't parse well"? The existing RDFa seems to parse just fine in both linter.structured-data.org and Google's structured data testing tool. If it's just a matter of changing <meta ... href> to <link ... href>, sure, that's arguably more correct. But due to historical (mal)practice schema.org parsers accept the meta...href formulation. I'll open a separate issue for that so that we can hit all of the <meta...href> examples globally. |
The workExample / exampleOfWork property examples were missing a JSON-LD example. This fills in that missing piece, based on an example that Richard Wallis provided. Fixes schemaorg#471. Signed-off-by: Dan Scott <dan@coffeecode.net>
The workExample / exampleOfWork property examples were missing a JSON-LD example. This fills in that missing piece, based on an example that Richard Wallis provided. Fixes schemaorg#471. Signed-off-by: Dan Scott <dan@coffeecode.net>
Looks like #77 is already covering some of the <meta ... href> space (although the focus there was on the more worrisome <meta ... content="http://example.com"> usage). |
@Dataliberate - I fixed the & above. (I guess I get an edit button as I'm an admin?) For the JSON, wouldn't it be simpler without schema: everywhere? |
Note that the branch in pull request #477 uses the JSON-LD provided by @Dataliberate as a base, with the schema: prefix stripped and minor changes to the indentation. |
Thanks everyone! I've just merged the pull request from @dbs :) |
schema.org/exampleOfWork and its inverse property, schema.org/workExample, both lack JSON-LD examples. They both have microdata and RDFa examples, but the JSON-LD is present but empty (and without any explanation about why it's empty).
The text was updated successfully, but these errors were encountered: