New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"an URL" used in docs repeatedly #498

Closed
connorshea opened this Issue May 15, 2015 · 8 comments

Comments

Projects
None yet
5 participants
@connorshea

connorshea commented May 15, 2015

"an URL" is grammatically incorrect, as "URL" is pronounced "you-are-el". "An" should only be used when the first sound of the next word begins with a vowel sound, rather than a consonant sound.

This issue is present a few times in schema.rdfa, specifically at Line 4591, Line 4563, and Line 10581.

Sources for the grammar rule:

@chaals

This comment has been minimized.

Show comment
Hide comment
@chaals

chaals May 15, 2015

Contributor

Actually a lot of people pronounce it "earl". In the absence of a Royal Academy of English Pronunciation, or a Presidential Commission, or an official by-law of the municipality of Booroondara that is recognised as authority, I think we shouldn't be overly concerned.

That said, consistency isn't inherently bad, and if we decide to "bikeshed" this issue to resolution I'd vote for "a URL" because I say it that way.

Contributor

chaals commented May 15, 2015

Actually a lot of people pronounce it "earl". In the absence of a Royal Academy of English Pronunciation, or a Presidential Commission, or an official by-law of the municipality of Booroondara that is recognised as authority, I think we shouldn't be overly concerned.

That said, consistency isn't inherently bad, and if we decide to "bikeshed" this issue to resolution I'd vote for "a URL" because I say it that way.

@danbri

This comment has been minimized.

Show comment
Hide comment
@danbri

danbri May 15, 2015

Contributor

Thanks for your attention to detail, @connorshea. I agree it would be good to be consistent on this, one way or another. This explains why it's "a unicorn" not "an unicorn", which I have wondered about occasionally; I'd heard the rule was letter-based rather than sound-based. As @chaals says, English is not pronounced very consistently so I don't think we can be super strict about these things. But converging on "a URL" sounds reasonable.

(wonder if @timbl has a view?)

Contributor

danbri commented May 15, 2015

Thanks for your attention to detail, @connorshea. I agree it would be good to be consistent on this, one way or another. This explains why it's "a unicorn" not "an unicorn", which I have wondered about occasionally; I'd heard the rule was letter-based rather than sound-based. As @chaals says, English is not pronounced very consistently so I don't think we can be super strict about these things. But converging on "a URL" sounds reasonable.

(wonder if @timbl has a view?)

@danbri

This comment has been minimized.

Show comment
Hide comment
@danbri

danbri May 15, 2015

Contributor

I'm assigning this issue to @shankarnat as he's looking for easy issues while learning our tooling/workflow.

Contributor

danbri commented May 15, 2015

I'm assigning this issue to @shankarnat as he's looking for easy issues while learning our tooling/workflow.

@shankarnat

This comment has been minimized.

Show comment
Hide comment
@shankarnat

shankarnat May 15, 2015

I have made changes and created a pull request to merge the change. @danbri can you please review ? Thanks!

shankarnat commented May 15, 2015

I have made changes and created a pull request to merge the change. @danbri can you please review ? Thanks!

@danbri

This comment has been minimized.

Show comment
Hide comment
@danbri

danbri May 15, 2015

Contributor

Thanks :) although I don't see it inhttps://github.com/schemaorg/schemaorg/pulls yet. But I am looking via phone, will double check when back on a laptop.

Contributor

danbri commented May 15, 2015

Thanks :) although I don't see it inhttps://github.com/schemaorg/schemaorg/pulls yet. But I am looking via phone, will double check when back on a laptop.

@unor

This comment has been minimized.

Show comment
Hide comment
@unor

unor May 15, 2015

Contributor

#500

Contributor

unor commented May 15, 2015

#500

@danbri

This comment has been minimized.

Show comment
Hide comment
@danbri

danbri May 15, 2015

Contributor

Great. LGTM :)

Contributor

danbri commented May 15, 2015

Great. LGTM :)

@shankarnat

This comment has been minimized.

Show comment
Hide comment
@shankarnat

shankarnat May 16, 2015

Closing this issue now! Thanks.

shankarnat commented May 16, 2015

Closing this issue now! Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment