-
Notifications
You must be signed in to change notification settings - Fork 825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add enumerated values for http://schema.org/paymentStatus #518
Comments
Implemented as pull request #523. |
/cc @mfhepp |
WfM. The feature creep in me looks for a partial payment made… |
@chaals is right - we likely need a mechanism for deposits and partial payment. Would PartialPaymentReceived as an additional value be sufficient? |
Done (manually) |
Looking at this, the enumeration wasn't showing up. I've tweaked the design from the pull request, s/Intangible/Enumeration/ and that does the job. We might also consider that PaymentDue ("The payment is due, but still within an acceptable time to be received.") is named almost identically to the existing property http://schema.org/paymentDue ("The date that payment is due."). I would prefer not to do this - can we rename it to something more distinctive? Related (if only by similar name) existing terms: |
See http://webschemas.org/PaymentStatusType for current release candidate (also in sdo-ganymede) |
+1 OrderPaymentDue |
That's from a different enumeration called http://schema.org/OrderStatus whose values are already: OrderCancelled Are these two views of the same transactions? I don't know if one enumerated value being in both enumerated lists will work very well (technically, at least). |
action: danbri test if multiple typing works |
Note that http://schema.org/OrderStatus and http://schema.org/orderStatus also both exist. I agree this should be avoided. Since enumeration items are types in schema.org, this is prone to happen again. Is there a lot of value in having those as types as opposed to literal values which would not be clashing with the types? |
Looking at this for the upcoming release, I am wary of (a) having one term (OrderPaymentDue) appear in two enumerations, as this will confuse navigation. The option (b) of converging the two lists I also believe unappealing, as they currently each address different situations: http://schema.org/OrderStatus vs http://sdo-ganymede.appspot.com/PaymentStatusType. I believe the simplest fix which allows us to proceed and improves clarity of existing terms is for the current paymentDue property to migrate to an new more explicit name: paymentDueDate.
|
Bit of research to answer the question... Q: Should property names end with 'date' or start with 'date'? |
We also confuse 'date' and 'time'. See issue #524 |
This clarifies its meaning and makes room for PaymentDue as an enumerated status value. For #518
Ok, I think we're done here. Please review c/o http://sdo-ganymede.appspot.com/docs/releases.html#sdo-ganymede |
http://schema.org/paymentStatus takes text. It would be nice to also take defined values. Initially, we should support the following and maybe others.
PaymentComplete
PaymentDue
PaymentPastDue
PaymentDeclined
The text was updated successfully, but these errors were encountered: