-
Notifications
You must be signed in to change notification settings - Fork 823
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Linter warnings on schema.org examples #53
Comments
Thanks Gregg. I'll try running your tool locally as otherwise the example IDs don't mean anything. I want to add explicit example IDs to all our examples btw, to help with such things. |
I've updated it to generate example names based on both the classes they're defined on and the ordinal position of the example from the source files. These are some of the following issues noted:
This indicates that the value of a
Perhaps this is okay with the schema.org data model, but "598 Pages" isn't an integer, but a text value.
Duration is supposed to use ISO8601, which I use for validating such datatypes. It's probably not an issue, but it is a valid linter warning IMO. The rest should be fairly self-explanatory.
|
These clearly deserve attention, I'm sorry we haven't got to them all yet! Pushing them to next release. |
Ok @gkellogg I finally got the linter running locally. Do you have a script handy that unpacks and checks the schema.org examples? |
@danbri side note: might be worth to run all the schema.org examples through the new Google validator at https://developers.google.com/webmasters/structured-data/testing-tool/ - you might have a way to send all those examples in batch and get the warnings/errors back. Maybe you have already done so, in which case ignore this comment. Happy to create a new issue if not. |
Yeah, we should do that! Thanks for the nudge, it's already on my todo list... |
From the linter directory, you can run |
Thanks Gregg! Note that Guha's master branch has graduated to an organization account within github now. Most Web links seem to redirect nicely, hopefully it will continue to work for you too. -> https://github.com/schemaorg/schemaorg There's still some admin/workflow setup to do but at least the basic shape of things is settling down. |
FYI the 'rake schema:examples' command wiped out the examples collection because sinatra-linkeddata failed (I think it wasn't installed properly) |
It needed
... and then generates a load of (very useful) output, then appears to hang at schema.org/UpdateAction-163-jsonld.html, file is... 41665 Jan 19 22:14 etc/schema-warnings.txt |
Thanks, I'll update the dependencies and check out the UpdateAction issue. |
FYI, to run locally, run Note that I have some fixes pending in PR #199 which you might want to pick up. I believe one of those fixes "solved" the JSON-LD hang. If you do the |
I used "bundle install --path vendor/bundler" per the readme. |
ping @RichardWallis ... re-assigning this to you, as I clearly didn't get to it! |
For desktop developer use I don't think it made sense to have a strong dependency on Ruby tooling, however now that we are generally wired into Travis-CI for our unit tests (thanks @lanthaler :), it is a good time to revisit this. We are already set up to skip the rdflib-based tests if that library is not available, so we could do similarly for the ruby-powered checks. See https://github.com/schemaorg/schemaorg/blob/sdo-callisto/tests/test_graphs.py#L57 |
I'm on it. |
https://travis-ci.org/schemaorg/schemaorg shows 141 markup errors. Let's try to get that down to respectable levels for our next release! We should also try to make sure that the examples use no terms that have been supersededBy another or moved to the attic.schema.org area. |
We have not much improved this situation. https://travis-ci.org/github/schemaorg/schemaorg/jobs/709160005 reports a bunch of issues, mix of vocabulary stuff and syntax. @RichardWallis - how about we work through them together? |
This issue is being tagged as Stale due to inactivity. |
Update: https://gist.github.com/danbri/c5fef76dcf89bc23bdb6 has a fresh run against 2015-01-28th snapshot of sdo-stantz branch. -- @danbri
FYI, the following are warnings produced by the Structured-Data Linter for current schema.org examples:
[ earlier results removed for readability, see link above ]
This was done through the following:
Changes to the schema.org RDFS need to be synchronized by updating the vocabulary in the RDF.rb gem, typically done after each release.
The text was updated successfully, but these errors were encountered: