MusicCompositions should have a way to specify the song lyrics #531

Closed
vholland opened this Issue May 22, 2015 · 3 comments

Projects

None yet

2 participants

@vholland
Contributor

MusicComposition has a lyricist property, but not a lyrics property. It would be nice to be able to specify the lyrics themselves.

@vholland vholland added a commit to vholland/schemaorg that referenced this issue May 22, 2015
@vholland vholland Issue #531: Added lyrics property to MusicComposition. 0582a61
@vholland
Contributor

See pull request #532.

@danbri danbri added this to the sdo-ganymede release milestone May 22, 2015
@danbri
Contributor
danbri commented May 22, 2015

I commented offtopic in the pull request, while meaning to comment offtopic in the issue :)

"Thanks! I was wondering if this should be attached more widely, but talked myself out of it.

If someone applies a 'lyrics' property to a thing typed only as e.g. VideoObject, some validators would probably complain. I think instead of adding 'lyrics' up at a safer generic level we should try to make the culture of schema.org validation softer. A reasonable interpretation of "x is a VideoObject and it has a lyrics property whose value is y" would be to conclude "oh, x is also probably a MusicComposition then". I don't believe its reasonable to require that every usage of "lyrics" on a VideoObject also requires the mention of a 2nd type, MusicComposition. This just adds weight for limited benefit."

@danbri
Contributor
danbri commented May 28, 2015

Fixed by #532

@danbri danbri closed this May 28, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment