New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MusicCompositions should have a way to specify the song lyrics #531

Closed
vholland opened this Issue May 22, 2015 · 3 comments

Comments

Projects
None yet
2 participants
@vholland
Contributor

vholland commented May 22, 2015

MusicComposition has a lyricist property, but not a lyrics property. It would be nice to be able to specify the lyrics themselves.

vholland added a commit to vholland/schemaorg that referenced this issue May 22, 2015

@vholland

This comment has been minimized.

Show comment
Hide comment
@vholland

vholland May 22, 2015

Contributor

See pull request #532.

Contributor

vholland commented May 22, 2015

See pull request #532.

@danbri danbri added this to the sdo-ganymede release milestone May 22, 2015

@danbri

This comment has been minimized.

Show comment
Hide comment
@danbri

danbri May 22, 2015

Contributor

I commented offtopic in the pull request, while meaning to comment offtopic in the issue :)

"Thanks! I was wondering if this should be attached more widely, but talked myself out of it.

If someone applies a 'lyrics' property to a thing typed only as e.g. VideoObject, some validators would probably complain. I think instead of adding 'lyrics' up at a safer generic level we should try to make the culture of schema.org validation softer. A reasonable interpretation of "x is a VideoObject and it has a lyrics property whose value is y" would be to conclude "oh, x is also probably a MusicComposition then". I don't believe its reasonable to require that every usage of "lyrics" on a VideoObject also requires the mention of a 2nd type, MusicComposition. This just adds weight for limited benefit."

Contributor

danbri commented May 22, 2015

I commented offtopic in the pull request, while meaning to comment offtopic in the issue :)

"Thanks! I was wondering if this should be attached more widely, but talked myself out of it.

If someone applies a 'lyrics' property to a thing typed only as e.g. VideoObject, some validators would probably complain. I think instead of adding 'lyrics' up at a safer generic level we should try to make the culture of schema.org validation softer. A reasonable interpretation of "x is a VideoObject and it has a lyrics property whose value is y" would be to conclude "oh, x is also probably a MusicComposition then". I don't believe its reasonable to require that every usage of "lyrics" on a VideoObject also requires the mention of a 2nd type, MusicComposition. This just adds weight for limited benefit."

danbri added a commit that referenced this issue May 28, 2015

Merge pull request #532 from vholland/music-lyrics
Issue #531: Added lyrics property to MusicComposition
@danbri

This comment has been minimized.

Show comment
Hide comment
@danbri

danbri May 28, 2015

Contributor

Fixed by #532

Contributor

danbri commented May 28, 2015

Fixed by #532

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment