videoFormat on TelevisionStation vs videoFormat on BroadcastService #577

Closed
morganyvm opened this Issue Jun 8, 2015 · 16 comments

Projects

None yet

6 participants

@morganyvm

Should not videoFormat be part of BroadcastService, like the third BroadcastService example, instead of part of TelevisionStation?
The (Broadcast)Service delivery the videoFormat. TelevisionStation is related to one or more BroadcastService, isn`t? Does it make sense? Anybody agree?

@danbri
Contributor
danbri commented Jun 8, 2015
@vholland
Contributor
vholland commented Jun 9, 2015

Oops. Yes. That is a bug in the RDFa. The example is correct.

@vholland vholland self-assigned this Jun 9, 2015
@danbri danbri added a commit that referenced this issue Jun 9, 2015
@danbri danbri Added a PRE-MARKUP section addressing #580 glitch. Also balanced a tag.
Needed for #577 so we can see the example under discussion :)
d8a0559
@danbri
Contributor
danbri commented Jun 9, 2015

ok I've fixed the non-display of the examples, and updated sdo-ganymede and webschemas test builds.

Looking at http://webschemas.org/ScreeningEvent and http://schema.org/BroadcastService proposal is to...

@danbri danbri added a commit that referenced this issue Jun 9, 2015
@danbri danbri BroadcastService and BroadcastEvent expect videoFormat; TelevisionSta…
…tion doesn't.

Tentative proposal for #577 (depending on conclusion on BroadcastEvent).
2ffa6a8
@danbri
Contributor
danbri commented Jun 9, 2015

Tentatively committed an implementation of the above, including BroadcastEvent.

Comments welcomed! How does http://sdo-ganymede.appspot.com/videoFormat look?

@danbri danbri added a commit that referenced this issue Jun 9, 2015
@danbri danbri Noted fix for videoFormat / #577 020b239
@vholland
Contributor
vholland commented Jun 9, 2015

+1 looks good to me.

@danbri
Contributor
danbri commented Jun 9, 2015

Ok, http://webschemas.org/docs/releases.html has the candidate release notes:

<li><a href="https://github.com/schemaorg/schemaorg/issues/577">Fix to #577</a>: 
Amended <a href="/videoFormat">videoFormat</a> to indicate that it is expected on
 <a href="/BroadcastEvent">BroadcastEvent</a> and <a href="/ScreeningEvent">ScreeningEvent</a>, 
rather than <a href="/TelevisionStation">TelevisionStation</a>.</li>
@danbri
Contributor
danbri commented Jun 9, 2015

@mika @shankarnat @tmarshbing @chaals @tilid @ajax-als - please take a look for final sanity check

@mika
mika commented Jun 9, 2015

@danbri Looks like you pinged the wrong mika

@danbri
Contributor
danbri commented Jun 9, 2015

Oops. Do feel free to +1 unless @pmika gets there first! Sorry for the noise...

@morganyvm

+1 looks good.
Tks you all!

@morganyvm morganyvm closed this Jun 9, 2015
@danbri
Contributor
danbri commented Jun 10, 2015

Thanks @morganyvm. Let's leave the issue open to give the others I cc:'d a change to take a look (though I think we're very likely done here).

@danbri danbri reopened this Jun 10, 2015
@morganyvm

@danbri sorry for that. I'm a newbie here.

@danbri
Contributor
danbri commented Jun 10, 2015

No worries, we haven't documented (or fully invented) conventions for everything here yet. Thanks again for catching this bug! :)

@shankarnat
Contributor

+1 Looks good.

@vholland
Contributor

Fixed in 2.1

@vholland vholland closed this Sep 15, 2015
@chaals
Contributor
chaals commented Sep 15, 2015

Works for me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment