-
Notifications
You must be signed in to change notification settings - Fork 851
1st Book example JSON-LD is buggy #644
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
The breadcrumb thing is odd. SDTT wants a proper Rating entity, so
becomes
|
Fixed JSON-LD to reflect this #644
Note #529 ... maybe we should strip out breadcrumb from these examples for now, until we clarify whether 'breadcrumb' (the property, vs BreadcrumbList) is still useful. |
Could do - and for now we could preserve a simplified version and attach it On Thu, Jul 16, 2015 at 12:58 PM, Dan Brickley notifications@github.com
|
Couldn't bring myself to make the microdata and rdfa so verbose though.
The Microdata and RDFa also mention WebPage; the JSON-LD mushes them together.
/cc @vholland
Other issues with this Book example:
the 'breadcrumb' property usage is goofy. Here I experiment with 'about' instead but we might want to just remove that now.
Google testing tool complains that the review/rating data is missing info. Does it have a point?
<script type="application/ld+json"> { "@context": "http://schema.org", "@type": "Book", "aggregateRating": { "@type": "AggregateRating", "ratingValue": "4", "reviewCount": "3077" }, "author": "/author/jd_salinger.html", "bookFormat": "http://schema.org/Paperback", "about": "Books > Literature & Fiction > Classics", "datePublished": "1991-05-01", "image": "catcher-in-the-rye-book-cover.jpg", "inLanguage": "English", "isbn": "0316769487", "name": "The Catcher in the Rye", "numberOfPages": "224", "offers": { "@type": "Offer", "availability": "http://schema.org/InStock", "price": "6.99", "priceCurrency": "USD" }, "publisher": "Little, Brown, and Company", "review": [ { "@type": "Review", "author": "John Doe", "datePublished": "2006-05-04", "name": "A masterpiece of literature", "reviewBody": "I really enjoyed this book. It captures the essential challenge people face as they try make sense of their lives and grow to adulthood.", "reviewRating": "5" }, { "@type": "Review", "author": "Bob Smith", "datePublished": "2006-06-15", "name": "A good read.", "reviewBody": "Catcher in the Rye is a fun book. It's a good book to read.", "reviewRating": "4" } ] } </script>The exact example is here: https://github.com/schemaorg/schemaorg/blob/sdo-ganymede/data/examples.txt#L1166
The text was updated successfully, but these errors were encountered: