Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1st Book example JSON-LD is buggy #644

Closed
danbri opened this issue Jul 13, 2015 · 3 comments
Closed

1st Book example JSON-LD is buggy #644

danbri opened this issue Jul 13, 2015 · 3 comments
Assignees

Comments

@danbri
Copy link
Contributor

@danbri danbri commented Jul 13, 2015

The Microdata and RDFa also mention WebPage; the JSON-LD mushes them together.

/cc @vholland

Other issues with this Book example:

  • the 'breadcrumb' property usage is goofy. Here I experiment with 'about' instead but we might want to just remove that now.

  • Google testing tool complains that the review/rating data is missing info. Does it have a point?

    <script type="application/ld+json"> { "@context": "http://schema.org", "@type": "Book", "aggregateRating": { "@type": "AggregateRating", "ratingValue": "4", "reviewCount": "3077" }, "author": "/author/jd_salinger.html", "bookFormat": "http://schema.org/Paperback", "about": "Books > Literature & Fiction > Classics", "datePublished": "1991-05-01", "image": "catcher-in-the-rye-book-cover.jpg", "inLanguage": "English", "isbn": "0316769487", "name": "The Catcher in the Rye", "numberOfPages": "224", "offers": { "@type": "Offer", "availability": "http://schema.org/InStock", "price": "6.99", "priceCurrency": "USD" }, "publisher": "Little, Brown, and Company", "review": [ { "@type": "Review", "author": "John Doe", "datePublished": "2006-05-04", "name": "A masterpiece of literature", "reviewBody": "I really enjoyed this book. It captures the essential challenge people face as they try make sense of their lives and grow to adulthood.", "reviewRating": "5" }, { "@type": "Review", "author": "Bob Smith", "datePublished": "2006-06-15", "name": "A good read.", "reviewBody": "Catcher in the Rye is a fun book. It's a good book to read.", "reviewRating": "4" } ] } </script>

The exact example is here: https://github.com/schemaorg/schemaorg/blob/sdo-ganymede/data/examples.txt#L1166

@vholland
Copy link
Contributor

@vholland vholland commented Jul 13, 2015

The breadcrumb thing is odd.

SDTT wants a proper Rating entity, so

"reviewRating": "5"

becomes

"reviewRating": { "@type": "Rating", "ratingValue": "5" }

@danbri
Copy link
Contributor Author

@danbri danbri commented Jul 16, 2015

Note #529 ... maybe we should strip out breadcrumb from these examples for now, until we clarify whether 'breadcrumb' (the property, vs BreadcrumbList) is still useful.

@RichardWallis
Copy link
Contributor

@RichardWallis RichardWallis commented Jul 17, 2015

Could do - and for now we could preserve a simplified version and attach it
to breadcrumb as a text example

On Thu, Jul 16, 2015 at 12:58 PM, Dan Brickley notifications@github.com
wrote:

Note #529 #529 ... maybe
we should strip out breadcrumb from these examples for now, until we
clarify whether 'breadcrumb' (the property, vs BreadcrumbList) is still
useful.


Reply to this email directly or view it on GitHub
#644 (comment)
.

danbri added a commit that referenced this issue Jul 24, 2015
Couldn't bring myself to make the microdata and rdfa so verbose though.
@danbri danbri closed this Jul 30, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.