New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate and broken CSS declarations should be cleaned up #654

Closed
danbri opened this Issue Jul 21, 2015 · 1 comment

Comments

Projects
None yet
1 participant
@danbri
Contributor

danbri commented Jul 21, 2015

schemaorg.css

diff docs/schemaorg.css static/search_files/schemaorg.css :(

  • make sure docs/schemaorg.css has everything needed from static/search_files/schemaorg.css
  • update Python + HTML + templates/ references to use the former
  • remove the CSS files that we no longer need, and static/search_files folder too.

We should converge towards the one in docs/ after checking nothing got lost.

Also prettify.css is mis-cited in some pages currently; the file is in docs/ not search_files/

danbri added a commit that referenced this issue Jul 23, 2015

Removing bogus duplicate copy of CSS, per #654.
I've compared this with docs/schemaorg.css manually and noted in
comments of latter the few differences. Mostly the docs/ version
only had additions.

danbri added a commit that referenced this issue Jul 23, 2015

Cleanup, mostly CSS refs and a few js.
grep "\.css" *.html
about.html:    <link rel="stylesheet" type="text/css" href="schemaorg.css" />
actions.html:    <link rel="stylesheet" type="text/css" href="schemaorg.css" />
actions.html:    <link href="prettify.css" type="text/css" rel="stylesheet" />
datamodel.html:    <link rel="stylesheet" type="text/css" href="schemaorg.css" />
datamodel.html:    <link href="prettify.css" type="text/css" rel="stylesheet" />
documentation.html:    <link rel="stylesheet" type="text/css" href="schemaorg.css" />
documents.html:    <link rel="stylesheet" type="text/css" href="schemaorg.css" />
extension.html:    <link rel="stylesheet" type="text/css" href="schemaorg.css" />
faq.html:    <link rel="stylesheet" type="text/css" href="schemaorg.css" />
feedback.html:    <link rel="stylesheet" type="text/css" href="schemaorg.css" />
gs.html:    <link rel="stylesheet" type="text/css" href="schemaorg.css" />
meddocs.html:    <link rel="stylesheet" type="text/css" href="schemaorg.css" />
meddocs.html:    <link href="prettify.css" type="text/css" rel="stylesheet" />
old_extension.html:    <link rel="stylesheet" type="text/css" href="schemaorg.css" />
releases.html:    <link rel="stylesheet" type="text/css" href="schemaorg.css" />
releases.html:    <link href="prettify.css" type="text/css" rel="stylesheet" />
schemas.html:    <link rel="stylesheet" type="text/css" href="/docs/schemaorg.css" />
search_results.html:    <link rel="stylesheet" type="text/css" href="schemaorg.css" />
terms.html:    <link rel="stylesheet" type="text/css" href="/docs/schemaorg.css" />

For #654

danbri added a commit that referenced this issue Jul 23, 2015

@danbri danbri referenced this issue Jul 23, 2015

Merged

Css cleanup #659

@danbri

This comment has been minimized.

Show comment
Hide comment
@danbri

danbri Jul 24, 2015

Contributor

Basics are done in this last merge. I can't find any HTML/CSS embedded in Python; templates, static docs and anything else should now be ok. While there are other CSS issues these are tracked in dedicated issues, so closing this one.

Contributor

danbri commented Jul 24, 2015

Basics are done in this last merge. I can't find any HTML/CSS embedded in Python; templates, static docs and anything else should now be ok. While there are other CSS issues these are tracked in dedicated issues, so closing this one.

@danbri danbri closed this Jul 24, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment