Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Duplicate and broken CSS declarations should be cleaned up #654

Closed
2 of 3 tasks
danbri opened this issue Jul 21, 2015 · 1 comment
Closed
2 of 3 tasks

Duplicate and broken CSS declarations should be cleaned up #654

danbri opened this issue Jul 21, 2015 · 1 comment
Labels
site tools + python code Infrastructural issues around schema.org site. Most can ignore this!

Comments

@danbri
Copy link
Contributor

danbri commented Jul 21, 2015

schemaorg.css

diff docs/schemaorg.css static/search_files/schemaorg.css :(

  • make sure docs/schemaorg.css has everything needed from static/search_files/schemaorg.css
  • update Python + HTML + templates/ references to use the former
  • remove the CSS files that we no longer need, and static/search_files folder too.

We should converge towards the one in docs/ after checking nothing got lost.

Also prettify.css is mis-cited in some pages currently; the file is in docs/ not search_files/
@danbri danbri added the site tools + python code Infrastructural issues around schema.org site. Most can ignore this! label Jul 21, 2015
@danbri danbri mentioned this issue Jul 23, 2015
Closed
danbri added a commit that referenced this issue Jul 23, 2015
@danbri
Preparing for major cleanup of CSS (in its own branch). See #653 and #…
d368ab6 
…654
danbri added a commit that referenced this issue Jul 23, 2015
@danbri
Removing bogus duplicate copy of CSS, per #654.
297666e 
I've compared this with docs/schemaorg.css manually and noted in
comments of latter the few differences. Mostly the docs/ version
only had additions.
danbri added a commit that referenced this issue Jul 23, 2015
@danbri
Cleanup, mostly CSS refs and a few js.
31324a3 
grep "\.css" *.html
about.html:    <link rel="stylesheet" type="text/css" href="schemaorg.css" />
actions.html:    <link rel="stylesheet" type="text/css" href="schemaorg.css" />
actions.html:    <link href="prettify.css" type="text/css" rel="stylesheet" />
datamodel.html:    <link rel="stylesheet" type="text/css" href="schemaorg.css" />
datamodel.html:    <link href="prettify.css" type="text/css" rel="stylesheet" />
documentation.html:    <link rel="stylesheet" type="text/css" href="schemaorg.css" />
documents.html:    <link rel="stylesheet" type="text/css" href="schemaorg.css" />
extension.html:    <link rel="stylesheet" type="text/css" href="schemaorg.css" />
faq.html:    <link rel="stylesheet" type="text/css" href="schemaorg.css" />
feedback.html:    <link rel="stylesheet" type="text/css" href="schemaorg.css" />
gs.html:    <link rel="stylesheet" type="text/css" href="schemaorg.css" />
meddocs.html:    <link rel="stylesheet" type="text/css" href="schemaorg.css" />
meddocs.html:    <link href="prettify.css" type="text/css" rel="stylesheet" />
old_extension.html:    <link rel="stylesheet" type="text/css" href="schemaorg.css" />
releases.html:    <link rel="stylesheet" type="text/css" href="schemaorg.css" />
releases.html:    <link href="prettify.css" type="text/css" rel="stylesheet" />
schemas.html:    <link rel="stylesheet" type="text/css" href="/docs/schemaorg.css" />
search_results.html:    <link rel="stylesheet" type="text/css" href="schemaorg.css" />
terms.html:    <link rel="stylesheet" type="text/css" href="/docs/schemaorg.css" />

For #654
danbri added a commit that referenced this issue Jul 23, 2015
@danbri
Cleaning CSS (and .js) links per #654
be463a0
@danbri danbri mentioned this issue Jul 23, 2015
Merged
@danbri
Copy link
Contributor Author

danbri commented Jul 24, 2015

Basics are done in this last merge. I can't find any HTML/CSS embedded in Python; templates, static docs and anything else should now be ok. While there are other CSS issues these are tracked in dedicated issues, so closing this one.

@danbri danbri closed this as completed Jul 24, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
site tools + python code Infrastructural issues around schema.org site. Most can ignore this!
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@danbri