Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GeoCoordinates improvements: allow address, mention wgs84 #802

Closed
danbri opened this issue Sep 28, 2015 · 5 comments
Closed

GeoCoordinates improvements: allow address, mention wgs84 #802

danbri opened this issue Sep 28, 2015 · 5 comments

Comments

@danbri
Copy link
Contributor

@danbri danbri commented Sep 28, 2015

This is a sub-issue of the longstanding #113 Geo* cleanup. WGS84 is implied (and used in the specs ours was based on) but wasn't mentioned. Also GeoCoordinates is hard to re-use / extend in extensions since address was a property of a Place that had the GeoCoordinates as value of a 'geo' property. We should allow the simple option of a GeoCoordinates directly carrying 'address' property.

@danbri danbri self-assigned this Sep 28, 2015
@danbri danbri added this to the sdo-phobos release milestone Sep 28, 2015
@danbri danbri closed this in a7189f8 Sep 28, 2015
danbri pushed a commit that referenced this issue Sep 28, 2015
Mentioned WGS84 on the properties, and marked 'address' as expected on GeoCoordinates.
Fixes #802.
@danbri danbri reopened this Sep 28, 2015
@pmika
Copy link
Collaborator

@pmika pmika commented Sep 28, 2015

+1

1 similar comment
@mfhepp
Copy link
Contributor

@mfhepp mfhepp commented Sep 28, 2015

+1

@danbri
Copy link
Contributor Author

@danbri danbri commented Sep 29, 2015

I forgot to include GeoShape here too - doing both for consistency. See also #808 which supports address having simple textual fields for when data is unstructured.

@shankarnat
Copy link
Collaborator

@shankarnat shankarnat commented Sep 30, 2015

+1

@danbri
Copy link
Contributor Author

@danbri danbri commented Nov 6, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.