Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GeoShape and GeoCoordinates should allow a postalCode [edit: + country] for rough positioning. #810

Closed
danbri opened this issue Sep 29, 2015 · 6 comments

Comments

@danbri
Copy link
Contributor

@danbri danbri commented Sep 29, 2015

Sub-issue of #113.

This is non-essential in that we can use GeoShape --address-- PostalAddress -- postalCode-- xyz.

But that is needlessly heavy, so let's pick out the most useful piece of PostalAddress for this purpose, postalCode. This fits well with the approach implemented in #808 which allows these to have a simple textual 'address' too.

@pmika
Copy link
Collaborator

@pmika pmika commented Sep 30, 2015

Does postalCode make sense without a country?

@danbri
Copy link
Contributor Author

@danbri danbri commented Sep 30, 2015

You're right. It would make more sense with a Country.

The most obvious options seem to be:

  • use address with a value of PostalAddress which has an addressCountry ...
  • allow addressCountry to apply to these types directly

In passing I note that Country says "You can also provide the two-letter ISO 3166-1 alpha-2 country code." but doesn't say which property of a Country would carry such a code (e.g. alternateName? should we add something?) [edit: rather - we don't say how the property would use the codes. We ALSO don't say how these codes would show up via the Country type, see #815).

@radusi
Copy link

@radusi radusi commented Sep 30, 2015

Hi,

Just as suggestion, some time ago I came across with a ISO standard for Addresses via UPU ( Universal Postal Union - upu.net ) .
The direction they go is ZIP CODE-COUNTRY, Thus maybe a format like Country ISO_3166-2 - Zip Code would satisfy ( ex. US-90210 would suffice ).

@danbri
Copy link
Contributor Author

@danbri danbri commented Sep 30, 2015

Thanks @radusi - I was also wondering in this direction, e.g. URI schemes, but I think both approaches are relatively obscure (even if the idea is very sensible).

danbri added a commit that referenced this issue Sep 30, 2015
We allow addressCountry on GeoShape and GeoCoordinates, and more
explicitly anticipate textual country code values.
@danbri danbri changed the title GeoShape and GeoCoordinates should allow a postalCode for rough positioning. GeoShape and GeoCoordinates should allow a postalCode [edit: + country] for rough positioning. Sep 30, 2015
@danbri
Copy link
Contributor Author

@danbri danbri commented Sep 30, 2015

I've committed some changes - see http://sdo-phobos.appspot.com/addressCountry

  • addressCountry can also be used on these geo-* types directly (i.e. why force verbosity here)
  • addressCountry schema finally matches its textual definition by anticipating Text values (i.e. the ISO country codes)

I believe these are both pretty sensible given the options...

@danbri
Copy link
Contributor Author

@danbri danbri commented Nov 6, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.