Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

containedIn (between Places) is named in the most annoying direction. Add inverseOf, containsPlace #811

Closed
danbri opened this issue Sep 29, 2015 · 9 comments
Closed

containedIn (between Places) is named in the most annoying direction. Add inverseOf, containsPlace #811

danbri opened this issue Sep 29, 2015 · 9 comments
Assignees
@danbri
Labels
schema.org vocab General top level tag for issues on the vocabulary type:cleanup + clarity Addresses wording fixes, ambiguities, confusion, bad examples etc
Milestone
sdo-phobos release

Comments

@danbri
Copy link
Contributor

danbri commented Sep 29, 2015

Let's rename containedIn to containedInPlace too.
@danbri danbri added the schema.org vocab General top level tag for issues on the vocabulary label Sep 29, 2015
@mfhepp
Copy link
Contributor

mfhepp commented Sep 29, 2015

I am fine with that, but I do not think it is too annoying as it stands ;-)
Note that we are using containedIn in the hotel proposal, so there is a potential merge conflict if you change the name at the time of adding my proposal.

@danbri
Copy link
Contributor Author

danbri commented Sep 29, 2015

Thanks, ack'd.

danbri added a commit that referenced this issue Sep 29, 2015
@danbri
Fix for #811 - gave containedIn a more Place-related name, and an inv…
4cad71e 
…erse.

Since most markup using this will start with the larger, outer place, this was long overdue.
@danbri
Copy link
Contributor Author

danbri commented Sep 29, 2015

Ok

... queued up at http://sdo-phobos.appspot.com/docs/releases.html#geo-contains PTAL

@danbri danbri added the type:cleanup + clarity Addresses wording fixes, ambiguities, confusion, bad examples etc label Sep 29, 2015
@danbri danbri self-assigned this Sep 29, 2015
@danbri danbri added this to the sdo-phobos release milestone Sep 29, 2015
@pmika
Copy link
Collaborator

pmika commented Sep 30, 2015

+1

1 similar comment
@scor
Copy link
Contributor

scor commented Sep 30, 2015

👍

@chaals
Copy link
Contributor

chaals commented Sep 30, 2015

Looks OK to me, but again, providing crossrefs between containedInPlace and containsPlace seems sensible

@danbri
Copy link
Contributor Author

danbri commented Sep 30, 2015

Thanks @chaals crossrefs in this case are built in, since we declare them to be inverses of each other - see links above

@danbri
Copy link
Contributor Author

danbri commented Oct 30, 2015

Queued for closure after next release. http://sdo-phobos.appspot.com/containedInPlace

@danbri
Copy link
Contributor Author

danbri commented Nov 6, 2015

Fixed in http://schema.org/docs/releases.html#v2.2 - thanks all

@danbri danbri closed this as completed Nov 6, 2015
@danbri danbri mentioned this issue Jun 21, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danbri danbri

Labels
schema.org vocab General top level tag for issues on the vocabulary type:cleanup + clarity Addresses wording fixes, ambiguities, confusion, bad examples etc
Projects
None yet
Milestone
sdo-phobos release
Development

No branches or pull requests
5 participants
@scor @danbri @mfhepp @pmika @chaals