containedIn (between Places) is named in the most annoying direction. Add inverseOf, containsPlace #811

danbri opened this Issue Sep 29, 2015 · 9 comments


None yet

5 participants

danbri commented Sep 29, 2015

Let's rename containedIn to containedInPlace too.

mfhepp commented Sep 29, 2015

I am fine with that, but I do not think it is too annoying as it stands ;-)
Note that we are using containedIn in the hotel proposal, so there is a potential merge conflict if you change the name at the time of adding my proposal.

danbri commented Sep 29, 2015

Thanks, ack'd.

@danbri danbri pushed a commit that referenced this issue Sep 29, 2015
Dan Brickley Fix for #811 - gave containedIn a more Place-related name, and an inv…

Since most markup using this will start with the larger, outer place, this was long overdue.
@danbri danbri self-assigned this Sep 29, 2015
@danbri danbri added this to the sdo-phobos release milestone Sep 29, 2015
pmika commented Sep 30, 2015


scor commented Sep 30, 2015


chaals commented Sep 30, 2015

Looks OK to me, but again, providing crossrefs between containedInPlace and containsPlace seems sensible

danbri commented Sep 30, 2015

Thanks @chaals crossrefs in this case are built in, since we declare them to be inverses of each other - see links above

danbri commented Oct 30, 2015

Queued for closure after next release.

danbri commented Nov 6, 2015
@danbri danbri closed this Nov 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment