-
Notifications
You must be signed in to change notification settings - Fork 851
Add explicit relationship between location, homeLocation and workLocation #823
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Make sense to me. You also mentioned being explicit about 'location' often having textual values...? I think we should do that too. |
Implemented and merged to sdo-phobos, thanks for the suggestion @scor! |
Great, thanks, looking better. Should we also generalize the description a little bit, right now it says "The location of the event, organization or action." Something like: The location of for example where the event is happening, an organization is located, or where an action takes place. |
Fixed in http://schema.org/docs/releases.html#v2.2 - thanks all |
@scor @danbri: I realize this is an older issue, but because it's relevant to the context of this dialogue.... In the same way that the gist of this PR was to unify Specifically, if nothing else, Text is expected for
I guess, in the spirit of these being related fields, is there any reason that they couldn't be even more uniform? 😄 |
The 'location' property is used on http://schema.org/Event. homeLocation and workLocation are properties of http://schema.org/Person. I would think all those properties are related, and in particular, homeLocation and workLocation should be sub-properties of location.
As a result, the description of 'location' should be generalized:
The text was updated successfully, but these errors were encountered: