New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add explicit relationship between location, homeLocation and workLocation #823

Closed
scor opened this Issue Oct 1, 2015 · 7 comments

Comments

Projects
None yet
3 participants
@scor
Contributor

scor commented Oct 1, 2015

The 'location' property is used on http://schema.org/Event. homeLocation and workLocation are properties of http://schema.org/Person. I would think all those properties are related, and in particular, homeLocation and workLocation should be sub-properties of location.

As a result, the description of 'location' should be generalized:

The location of the event, organization or action.

@danbri

This comment has been minimized.

Show comment
Hide comment
@danbri

danbri Oct 1, 2015

Contributor

Make sense to me. You also mentioned being explicit about 'location' often having textual values...? I think we should do that too.

Contributor

danbri commented Oct 1, 2015

Make sense to me. You also mentioned being explicit about 'location' often having textual values...? I think we should do that too.

@danbri

This comment has been minimized.

Show comment
Hide comment
@danbri

danbri Oct 2, 2015

Contributor

Implemented and merged to sdo-phobos, thanks for the suggestion @scor!

http://sdo-phobos.appspot.com/location

Contributor

danbri commented Oct 2, 2015

Implemented and merged to sdo-phobos, thanks for the suggestion @scor!

http://sdo-phobos.appspot.com/location

@scor

This comment has been minimized.

Show comment
Hide comment
@scor

scor Oct 2, 2015

Contributor

Great, thanks, looking better. Should we also generalize the description a little bit, right now it says "The location of the event, organization or action."

Something like: The location of for example where the event is happening, an organization is located, or where an action takes place.

Contributor

scor commented Oct 2, 2015

Great, thanks, looking better. Should we also generalize the description a little bit, right now it says "The location of the event, organization or action."

Something like: The location of for example where the event is happening, an organization is located, or where an action takes place.

@danbri

This comment has been minimized.

Show comment
Hide comment
@danbri

danbri Oct 2, 2015

Contributor

Thanks @scor - done! /cc #827 as we're in final review now.

Contributor

danbri commented Oct 2, 2015

Thanks @scor - done! /cc #827 as we're in final review now.

@danbri

This comment has been minimized.

Show comment
Hide comment
@danbri

This comment has been minimized.

Show comment
Hide comment
@danbri
Contributor

danbri commented Nov 6, 2015

@danbri danbri closed this Nov 6, 2015

@dsimmons

This comment has been minimized.

Show comment
Hide comment
@dsimmons

dsimmons Mar 22, 2016

@scor @danbri: I realize this is an older issue, but because it's relevant to the context of this dialogue....

In the same way that the gist of this PR was to unify location, workLocation, and homeLocation, is there any way that we could unify the expected types?

Specifically, if nothing else, Text is expected for location, whereas it's not for homeLocation and workLocation.

location also supports PostalAddress, whereas homeLocation and workLocation don't (and instead support ContactPoint).

I guess, in the spirit of these being related fields, is there any reason that they couldn't be even more uniform? 😄

dsimmons commented Mar 22, 2016

@scor @danbri: I realize this is an older issue, but because it's relevant to the context of this dialogue....

In the same way that the gist of this PR was to unify location, workLocation, and homeLocation, is there any way that we could unify the expected types?

Specifically, if nothing else, Text is expected for location, whereas it's not for homeLocation and workLocation.

location also supports PostalAddress, whereas homeLocation and workLocation don't (and instead support ContactPoint).

I guess, in the spirit of these being related fields, is there any reason that they couldn't be even more uniform? 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment