Add explicit relationship between location, homeLocation and workLocation #823

Closed
scor opened this Issue Oct 1, 2015 · 7 comments

Projects

None yet

3 participants

@scor
Contributor
scor commented Oct 1, 2015

The 'location' property is used on http://schema.org/Event. homeLocation and workLocation are properties of http://schema.org/Person. I would think all those properties are related, and in particular, homeLocation and workLocation should be sub-properties of location.

As a result, the description of 'location' should be generalized:

The location of the event, organization or action.

@danbri
Contributor
danbri commented Oct 1, 2015

Make sense to me. You also mentioned being explicit about 'location' often having textual values...? I think we should do that too.

@danbri danbri added this to the sdo-phobos release milestone Oct 1, 2015
@danbri danbri self-assigned this Oct 1, 2015
@danbri danbri pushed a commit that referenced this issue Oct 2, 2015
Dan Brickley Marked homeLocation, workLocation as subproperties of location, per #823


Marked location as expecting textual values.
b6cf06d
@danbri
Contributor
danbri commented Oct 2, 2015

Implemented and merged to sdo-phobos, thanks for the suggestion @scor!

http://sdo-phobos.appspot.com/location

@scor
Contributor
scor commented Oct 2, 2015

Great, thanks, looking better. Should we also generalize the description a little bit, right now it says "The location of the event, organization or action."

Something like: The location of for example where the event is happening, an organization is located, or where an action takes place.

@danbri danbri pushed a commit that referenced this issue Oct 2, 2015
Dan Brickley Improved location descriptive text to match #823 changes. 76cc849
@danbri
Contributor
danbri commented Oct 2, 2015

Thanks @scor - done! /cc #827 as we're in final review now.

@danbri
Contributor
danbri commented Nov 6, 2015
@danbri danbri closed this Nov 6, 2015
@dsimmons

@scor @danbri: I realize this is an older issue, but because it's relevant to the context of this dialogue....

In the same way that the gist of this PR was to unify location, workLocation, and homeLocation, is there any way that we could unify the expected types?

Specifically, if nothing else, Text is expected for location, whereas it's not for homeLocation and workLocation.

location also supports PostalAddress, whereas homeLocation and workLocation don't (and instead support ContactPoint).

I guess, in the spirit of these being related fields, is there any reason that they couldn't be even more uniform? 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment