Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #818: Changed hasOfferCatalog to serviceDetails and added OfferCatalog to the range for makesOffer. #843

Closed
wants to merge 2 commits into from
Closed

Issue #818: Changed hasOfferCatalog to serviceDetails and added OfferCatalog to the range for makesOffer. #843

wants to merge 2 commits into from

Conversation

vholland
Copy link
Contributor

No description provided.

@vholland vholland mentioned this pull request Oct 13, 2015
Closed
@mfhepp
Copy link
Contributor

mfhepp commented Oct 13, 2015

+1 looks good to me.

@danbri
Copy link
Contributor

danbri commented Oct 21, 2015

@rvguha dissents - see #818 for discussion (and let's try to keep high level discussion in the issues not the pull requests).

@vholland vholland closed this Oct 27, 2015
@vholland vholland deleted the offer-fixes branch October 27, 2015 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vholland @mfhepp @danbri