Skip to content

thumbnail (ImageObject) missing in MediaObject #874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dmejia opened this issue Nov 6, 2015 · 7 comments
Closed

thumbnail (ImageObject) missing in MediaObject #874

dmejia opened this issue Nov 6, 2015 · 7 comments
Labels
no-issue-activity Discuss has gone quiet. Auto-tagging to encourage people to re-engage with the issue (or close it!). schema.org vocab General top level tag for issues on the vocabulary type:bug A mistake or malfunction whose remedy should be straightforward technical work

Comments

@dmejia
Copy link

dmejia commented Nov 6, 2015

MediaObject has a thumbnailUrl field but it lacks a full ImageObject thumbnail field that could be used for additional image information.
ImageObject and VideoObject do support a thumbnail already (which is confusing given that they also have a thumbnailUrl).
Can the thumbnailUrl be superseded by a thumbnail field that supports both a URL and an ImageObject? This is what's done already for http://schema.org/image

@chaals
Copy link
Contributor

chaals commented Nov 6, 2015

makes a lot of sense - should just be a case of deprecating thumbnailURL property and replacing it with the thumbnail property, no?

@chaals chaals added type:bug A mistake or malfunction whose remedy should be straightforward technical work schema.org vocab General top level tag for issues on the vocabulary labels Nov 6, 2015
@VladimirAlexiev
Copy link

I also vote for deprecating thumbnailUrl.
Moving the domain of thumbnail upward to MediaObject is the best approach.

@github-actions
Copy link

This issue is being tagged as Stale due to inactivity.

@github-actions github-actions bot added the no-issue-activity Discuss has gone quiet. Auto-tagging to encourage people to re-engage with the issue (or close it!). label Aug 12, 2020
@BrandtH22
Copy link
Contributor

I am looking to incorporate schema.org into our project and this issue is preventing us from doing so.

Can this issue be re-opened to deprecate thumbnailUrl in place of thumbnail?

@BrandtH22
Copy link
Contributor

This issue appears to be two-fold:
1 - expanding thumbnail domain to encompass that which is covered by thumbnailUrl
2 - deprecating thumbnailUrl.

Since 2 is more thoroughly discussed in issue #239 I recommend this issue focus on 1.
I have created a PR that will expand the scope of thumbnail to match that of thumbnailUrl and will tag this issue in it.

@danbri
Copy link
Contributor

danbri commented Apr 14, 2023

The “consistency with the earlier thumbnailUrl” argument makes sense, as does the ability to have thumbnails expressed against arbitrary other objects without trying to enumerate them.

Thanks, all! /cc @RichardWallis - Richard could you add to release notes?

@danbri
Copy link
Contributor

danbri commented May 20, 2023

Done!

@danbri danbri closed this as completed May 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-issue-activity Discuss has gone quiet. Auto-tagging to encourage people to re-engage with the issue (or close it!). schema.org vocab General top level tag for issues on the vocabulary type:bug A mistake or malfunction whose remedy should be straightforward technical work
Projects
None yet
Development

No branches or pull requests

5 participants