Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove @value from datePublished in Periodical JSON-LD examples #904

Closed
dbs opened this issue Nov 23, 2015 · 4 comments
Closed

Remove @value from datePublished in Periodical JSON-LD examples #904

dbs opened this issue Nov 23, 2015 · 4 comments

Comments

@dbs
Copy link
Contributor

@dbs dbs commented Nov 23, 2015

As noted by @Aaranged and related to #903, the JSON-LD examples for Periodical / ScholarlyArticle examples currently contain unnecessary @value stanzas that complicate the otherwise straightforward datePublished attributes. These should be removed.

dbs added a commit to dbs/schemaorg that referenced this issue Nov 23, 2015
The JSON-LD examples for ScholarlyArticle included unnecessary @value
clauses due to a naive conversion from the RDFa source. Remove them, so
instead of:

      "datePublished": {
        "@value": "2006-10",
        "@type": "xsd:gYearMonth"
      },

we'll have the much simpler, easier to publish and consume:

      "datePublished": "2006-10",

Fixes schemaorg#904.

Signed-off-by: Dan Scott <dan@coffeecode.net>
@dbs
Copy link
Contributor Author

@dbs dbs commented Nov 23, 2015

See dbs@8ecbfe0 for a commit that resolves this issue.

@chaals
Copy link
Contributor

@chaals chaals commented Dec 1, 2015

+1

@danbri
Copy link
Contributor

@danbri danbri commented Dec 9, 2015

@dbs - can you send a PR against our master branch? I tried to figure a way to do this without bugging you but have totally failed!

dbs added a commit to dbs/schemaorg that referenced this issue Dec 9, 2015
The JSON-LD examples for ScholarlyArticle included unnecessary @value
clauses due to a naive conversion from the RDFa source. Remove them, so
instead of:

      "datePublished": {
        "@value": "2006-10",
        "@type": "xsd:gYearMonth"
      },

we'll have the much simpler, easier to publish and consume:

      "datePublished": "2006-10",

Fixes schemaorg#904.

Signed-off-by: Dan Scott <dan@coffeecode.net>
@RichardWallis
Copy link
Contributor

@RichardWallis RichardWallis commented Mar 7, 2016

Fixed in #926

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.