New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove @value from datePublished in Periodical JSON-LD examples #904

Closed
dbs opened this Issue Nov 23, 2015 · 4 comments

Comments

Projects
None yet
4 participants
@dbs
Contributor

dbs commented Nov 23, 2015

As noted by @Aaranged and related to #903, the JSON-LD examples for Periodical / ScholarlyArticle examples currently contain unnecessary @value stanzas that complicate the otherwise straightforward datePublished attributes. These should be removed.

dbs added a commit to dbs/schemaorg that referenced this issue Nov 23, 2015

Remove @value clauses from Periodical JSON-LD examples
The JSON-LD examples for ScholarlyArticle included unnecessary @value
clauses due to a naive conversion from the RDFa source. Remove them, so
instead of:

      "datePublished": {
        "@value": "2006-10",
        "@type": "xsd:gYearMonth"
      },

we'll have the much simpler, easier to publish and consume:

      "datePublished": "2006-10",

Fixes #904.

Signed-off-by: Dan Scott <dan@coffeecode.net>
@dbs

This comment has been minimized.

Show comment
Hide comment
@dbs

dbs Nov 23, 2015

Contributor

See dbs@8ecbfe0 for a commit that resolves this issue.

Contributor

dbs commented Nov 23, 2015

See dbs@8ecbfe0 for a commit that resolves this issue.

@chaals

This comment has been minimized.

Show comment
Hide comment
@chaals

chaals Dec 1, 2015

Contributor

+1

Contributor

chaals commented Dec 1, 2015

+1

@danbri

This comment has been minimized.

Show comment
Hide comment
@danbri

danbri Dec 9, 2015

Contributor

@dbs - can you send a PR against our master branch? I tried to figure a way to do this without bugging you but have totally failed!

Contributor

danbri commented Dec 9, 2015

@dbs - can you send a PR against our master branch? I tried to figure a way to do this without bugging you but have totally failed!

dbs added a commit to dbs/schemaorg that referenced this issue Dec 9, 2015

Remove @value clauses from Periodical JSON-LD examples
The JSON-LD examples for ScholarlyArticle included unnecessary @value
clauses due to a naive conversion from the RDFa source. Remove them, so
instead of:

      "datePublished": {
        "@value": "2006-10",
        "@type": "xsd:gYearMonth"
      },

we'll have the much simpler, easier to publish and consume:

      "datePublished": "2006-10",

Fixes #904.

Signed-off-by: Dan Scott <dan@coffeecode.net>
@RichardWallis

This comment has been minimized.

Show comment
Hide comment
@RichardWallis

RichardWallis Mar 7, 2016

Contributor

Fixed in #926

Contributor

RichardWallis commented Mar 7, 2016

Fixed in #926

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment