Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extend range of isBasedOnUrl to Thing (or CreativeWork); rename to isBasedOn (or basedOn?) #950

Closed
sballesteros opened this issue Jan 5, 2016 · 3 comments

Comments

@sballesteros
Copy link
Author

@sballesteros sballesteros commented Jan 29, 2016

see also #975

@danbri
Copy link
Contributor

@danbri danbri commented Apr 5, 2016

Re-opening: should isBasedOnUrl have become basedOn instead of isBasedOn?

@danbri danbri changed the title extend range of isBasedOnUrl to Thing (or CreativeWork) and possibly rename to isBasedOn extend range of isBasedOnUrl to Thing (or CreativeWork); rename to isBasedOn (or basedOn?) Apr 5, 2016
@danbri
Copy link
Contributor

@danbri danbri commented Apr 5, 2016

Ok, I looked it up. We have lots of relational properties with names beginning with "is*", so this is ok.

  • isRelatedTo, isSimilarTo, isVariantOf, isConsumableFor, isBasedOnUrl, isPartOf, isAccessoryOrSparePartFor (relational)
  • isAccessibleForFree,isGift, isFamilyFriendly, isLiveBroadcast (boolean valued)

I think we're ok.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.