3 properties should use DateTime instead of Date #996

Closed
vberkel opened this Issue Feb 19, 2016 · 8 comments

Projects

None yet

5 participants

@vberkel
vberkel commented Feb 19, 2016

3 properties ( startDate endDate and commentTime ) have as their range a Date and yet expect a ISO8601 values that include the time (indicated in their comment). The model restricts an Event to have startDate or endDate without time which isn't the intention. Change their property range from Date to DateTime.

Alternatively, change startDate to startTime, endDate to endTime.

@danbri
Contributor
danbri commented Mar 7, 2016

Thanks, this seems fair. Another option would be to say that either "Date" or "DateTime" are appropriate values.

@akuckartz

http://purl.org/dc/terms/W3CDTF😄

@vberkel
vberkel commented Mar 8, 2016

I like your option the best; that would best allow events that are "all day" or at specific times.

@danbri
Contributor
danbri commented Jul 27, 2016

bump

Any objections to adding DateTime and leaving Date there too?

@scor @mfhepp @rvguha @chaals @shankarnat @vholland @tmarshbing

@danbri danbri self-assigned this Jul 27, 2016
@mfhepp
Contributor
mfhepp commented Jul 27, 2016

@danbri ok

@danbri danbri pushed a commit that referenced this issue Jul 27, 2016
Dan Brickley Added DateTime to expected values for startDate, endDate, commentTime.
See #996
8f83030
@scor
Contributor
scor commented Jul 27, 2016

👍

@danbri danbri pushed a commit that referenced this issue Jul 28, 2016
Dan Brickley Noted #996 e6fa4e2
@danbri
Contributor
danbri commented Jul 28, 2016

Implemented + queued for review in upcoming release: http://webschemas.org/docs/releases.html#g996

@danbri danbri closed this Aug 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment