New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3 properties should use DateTime instead of Date #996

Closed
vberkel opened this Issue Feb 19, 2016 · 8 comments

Comments

Projects
None yet
5 participants
@vberkel

vberkel commented Feb 19, 2016

3 properties ( startDate endDate and commentTime ) have as their range a Date and yet expect a ISO8601 values that include the time (indicated in their comment). The model restricts an Event to have startDate or endDate without time which isn't the intention. Change their property range from Date to DateTime.

Alternatively, change startDate to startTime, endDate to endTime.

@danbri

This comment has been minimized.

Show comment
Hide comment
@danbri

danbri Mar 7, 2016

Contributor

Thanks, this seems fair. Another option would be to say that either "Date" or "DateTime" are appropriate values.

Contributor

danbri commented Mar 7, 2016

Thanks, this seems fair. Another option would be to say that either "Date" or "DateTime" are appropriate values.

@akuckartz

This comment has been minimized.

Show comment
Hide comment
@akuckartz

akuckartz Mar 7, 2016

http://purl.org/dc/terms/W3CDTF😄

akuckartz commented Mar 7, 2016

http://purl.org/dc/terms/W3CDTF😄

@vberkel

This comment has been minimized.

Show comment
Hide comment
@vberkel

vberkel Mar 8, 2016

I like your option the best; that would best allow events that are "all day" or at specific times.

vberkel commented Mar 8, 2016

I like your option the best; that would best allow events that are "all day" or at specific times.

@danbri

This comment has been minimized.

Show comment
Hide comment
@danbri

danbri Jul 27, 2016

Contributor

bump

Any objections to adding DateTime and leaving Date there too?

@scor @mfhepp @rvguha @chaals @shankarnat @vholland @tmarshbing

Contributor

danbri commented Jul 27, 2016

bump

Any objections to adding DateTime and leaving Date there too?

@scor @mfhepp @rvguha @chaals @shankarnat @vholland @tmarshbing

@danbri danbri self-assigned this Jul 27, 2016

@mfhepp

This comment has been minimized.

Show comment
Hide comment
@mfhepp

mfhepp Jul 27, 2016

Contributor

@danbri ok

Contributor

mfhepp commented Jul 27, 2016

@danbri ok

@scor

This comment has been minimized.

Show comment
Hide comment
@scor

scor Jul 27, 2016

Contributor

👍

Contributor

scor commented Jul 27, 2016

👍

danbri added a commit that referenced this issue Jul 28, 2016

@danbri

This comment has been minimized.

Show comment
Hide comment
@danbri

danbri Jul 28, 2016

Contributor

Implemented + queued for review in upcoming release: http://webschemas.org/docs/releases.html#g996

Contributor

danbri commented Jul 28, 2016

Implemented + queued for review in upcoming release: http://webschemas.org/docs/releases.html#g996

@danbri danbri closed this Aug 10, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment