-
Notifications
You must be signed in to change notification settings - Fork 834
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
First draft of medicalEntity extension proposal #11
Conversation
This is a huge change. At a basic submission process level, I would recommend:
After a quick glance at the patch, I would recommend at least the following (there is probably more that a deeper analysis would draw out):
Overly generic type and property name alerts (perhaps prefix with "Medical"?):
QualifierConcept - perhaps this would be superseded by the simple SKOS proposal? belongsTo - might overlap with a property from the Periodical proposal |
New updated file is committed with suggestions made and approved by the WG. At a basic submission process level, I would recommend: -taking out the inline comment to danbri (we don't really want those comments in the production version of schema.org) -double-checking the patch (there are duplicate entries for Birth and BodySubstance) After a quick glance at the patch, I would recommend at least the following (there is probably more that a deeper analysis would draw out): -changing Hormonetherapy to HormoneTherapy Overly generic type and property name alerts (perhaps prefix with "Medical"?): QualifierConcept - perhaps this would be superseded by the simple SKOS proposal?
belongsTo - might overlap with a property from the Periodical proposal
ThanksThanks for this quick feedback Dan Scott. Well, it's a quite huge patch, this is a healthcare community effort So I agree with you, about the real git message. We have prepared a whole The recommendations are implemented (except renaming property--- will do it Tomorrow I will commit the updated file. Thanks Marc On 8 May 2014 22:12, Dan Scott notifications@github.com wrote:
|
Hi. Thanks for the proposal. As Dan mentions, it is (by schema.org standards) a large proposal. It will take some time to digest. I took a very quick skim through the document (I can't find a 'diff' view in the github UI for some reason). Some quick notes on issues that jump out at me:
-> The IHTSDO website is currently being reorganized to make it easier to navigate. Unfortunately one effect of this is to change the addresses of some pages ... did the snomed site change since you created these links? We should probably document a clearer approach for expressing mappings to external types/properties. So far we've used owl:equivalentProperty experimentally, so that rangeIncludes and domainIncludes are only used for internal links.
deathPlace
Specifying the place of death for a person
Domain: http://schema.org/Person
Domain: Death
Range: http://snomed.info/169812000
-> no mention of Place here? or in the other place-related proposed types?
familyHistory
Specifying a personal history as a part of a full medical history provided by the patient during an anamnesis procedure .
Domain: http://schema.org/Person
Range: http://snomed.info/57177007
SubProperty of: medicalHistory
... is this family medical history? In the previous medical/health additions we made the mistake of including terms whose name was implicitly contextualised to medical/health scenarios. So we 'used up' the word 'action' on a property that we now call http://schema.org/muscleAction and so on. We need to be very careful not to do this again - so every change needs to make sense cross domain, since schema.org is a cross domain vocabulary.
Related - the family tree stuff should be reconciled with non-medical family history use cases, https://www.w3.org/wiki/WebSchemas/HistoricalDataSchema ... esp considering cases like adoption, where implying 'biological parent' may be inappropriate and exclude reasonable usage. Have you tried running the site with AppEngine to see if this schema is read properly? |
Thanks Dan. All your suggestions are relevant and have been implemented. Some comments within the text below: ...Range: decimal
All snomed ct concepts will follow this principle. We welcome discussions at schema.org level about to document a clearer approach for expressing mappings to external types/properties. ... Related - the family tree stuff should be reconciled with non-medical family history use cases, https://www.w3.org/wiki/WebSchemas/HistoricalDataSchema ... esp considering cases like adoption, where implying 'biological parent' may be inappropriate and exclude reasonable usage. Have you tried running the site with AppEngine to see if this schema is read properly? The reworked file will be committed in asap with pull request. |
…nating duplicates, namespace/URI changes, retracting the properties biologicalFather/biologicalMother initial quick feedback from Dan & Dan
Minor fixing |
twamarc, can you outline any expected use of this new vocabulary? are any publishers or consumers currently involved with the proposal? |
Current use: Consumers /also involved in proposal design:
Tools and services developed by SALUS EU Project using the properties/classes included in the proposal (all will be openSource):
Expected use:
Personal note:
People involved in the initial proposal drafting (I will not quote all people who interacted in mailing list/Google group):
|
Just a note: As indicated earlier, this proposal is quite extensive and I feel that if we want the average medical website to start making use of it as well, than an effort to make providers of medical care become aware of it and some guidance in implementing it has to be made as well. Now in regards to the expected use, if there's any support needed in making of code examples, test-cases, feedback about usability from a web developer's perspective, etc, just let me know. I'm always happy to help out. |
ScheMed use perspective: |
Thanks for the extra background information. Have you had any success yet in running a copy of the schema.org site software using the RDFa patched in this pull request? It would also be great to have a high level overview of the principle changes, since these are difficult to discern from a textual diff of the schemas. What are the main changes here? Are there non-backwards-compatible edits, for example? |
Unfortunately we do not have the Google App Engine to run the RDFa patched in this pull request. The patch is mainly additions and is following the schema.org phylosopy/best practices. We avoided some discussions interfering with high-level schema.org design. There is however one point new in the patch (not really new following the discussions on it), it is the use of snomed ct classes as object of domainIncludes/rangeIncludes. On properties: The big merge with all very recent updates in schema.org (typo fixing, US english use, etc...) will be done at final stage to avoid granular separates commits. |
I'd be willing to help, if I only knew how to use the software. 2014-06-03 11:34 GMT+02:00 Marc notifications@github.com:
Jarno van Driel Tel: +31 652 847 608 |
The site software is a very basic Google App Engine python application. The only complexity should be the basic installation of AppEngine. On OSX this is very self contained. On Windows, I understand that there is more difficulty since you need to install Python yourself. Once you appengine.google.com working (and a basic understanding of the appengine approach) it should be trivial. I suggest first getting appengine running, then trying it with the standard lateset version of this repo; once you've achieved that, it should be easy to test and adapt the RDFa. |
Thanks to Giovani, Kristof and Jos (ACA team), we have run a copy of the schema.org site software using the RDFa patched in this pull request and the tests were successful. We could also browse throughout the classes and properties. There was one test failing, even from the origin rdfa file, the following: Do you know why? |
I'm glad you have the site running! Thanks for the note on the test failing. The tests are new, and there was a mistake which I had fixed in data but not in code. This shows I should run tests on every commit, rather than on every site release! You can ignore this test. I've replaced it with def test_acceptedAnswerSuperpropertiesArrayLen(self): but will post those changes later as I'm trying to set up a branch/fork structure for cleaner workflow. Regarding docs/ they aren't currently autogenerated. I'll work on the 'full view' page next week. |
…e best practice in schema.org
Do you have a human-oriented overview of the main changes in this proposal? How many are fixes versus additions, etc.? |
Comparing the existing schema.rdfa file and the medicalEntity.rdfa patch there are in total 2569 additions, 7 fixes (addition of subPropertyOf/subClassOf in existing properties/classes) , 0 changes and 0 deletions. |
Release cleanup.
Merge branch 'master' of https://github.com/twamarc/schemaorg into twamarc-master
I made a new PR #1056 targetting sdo-deimos, and have (with some manual tweaks) just merged it into that branch for review. |
This (PR #1056) needs some review. From a quick look, some core properties have been wrongly pulled into the extension. For example 'status' and 'purpose' They may be modified in the extension (eg. extending the domain and/or range) but their original definition belongs in the core. |
Yes, review is what it needs. There is a very rough first cut up at http://health-lifesci.webschemas.org/ but note that I've not yet made the general front page text, so it just gives a big ugly list of terms from the extension. However you can also navigate in from http://webschemas.org/docs/meddocs.html (btw think of webschemas.org as a volatile work-in-progress upstream test version, in sync with the latest proposed changes committed to our next release branch) |
Good progress! Thanks |
MedicalScholarlyArticle seems needless. I understand a wish to introduce the pubType field, but the terms listed by MeSH are generic and apply to any ScholarlyArticle. I would prefer to see it added then to that type. |
@egonw for better or worse, we have had http://schema.org/MedicalScholarlyArticle since http://blog.schema.org/2012/06/health-and-medical-vocabulary-for.html in 2012. The bulk of the work in this set of changes is to move the super-detailed medical and health vocabulary that we already have into a dedicated health-lifesci extension, where other related efforts can also live. |
@twamarc if you have further change suggestions it may be best to outline them here textually, rather than via Pull Request. If you do make a pull request, it should be based on the current state of the sdo-deimos branch here to avoid complexity. |
(I'm going to close the pull request since it has effectively been merged, but we can continue to discuss here) |
@danbri : Thanks. Maybe we can completery close this thread and follow the comments, improvements at
|
Sounds good, #492 it is. |
Edit: please see #492 for 2015 status of this work, using the new http://schema.org/docs/extension.html mechanism.
Dear colleagues,
I am pleased to introduce to you this healthcare community effort initiated in June 2013, to extend the medicalEntity vocabulary of schema.org. This aims to enable the use of schema.org not only in indexing health records, web, healthcare documents but also as a pillar source of medical ontology/vocabulary for formalization of healthcare information, exchange and interoperability and use in HL7 standards, CCD/C-CDA elements based APIs.
The intention here is neither to have a comprehensive medical ontology nor to define or codify a new controlled medical vocabulary, but to provide a scalable, use-driven vocabulary schema, in-line with the schema.org philosophy. In this design, few granular classes will be created, the priority is given to use the vocabulary in clinical information models which use classes from existing vocabularies and terminology (SNOMED, ICD, LOINC, ATC, RxNorm,etc.) and all properties from schema.org as pillar source.
This approach have been tested and used within SALUS EU FP7 project and was successful. All tools and services produced in SALUS EU FP7 project are public and accessible.
Expected use:
In line with healthcare IT community new initiatives (HL7 FHIR, CIMI, OpenEHR etc) and the real need in interoperability, the trend is now to develop clinical models not using local/internal ontology or a proper new ontology but only 3rd party ontology. This is the momentum for schema.org to contribute to the healthcare information, exchange and interoperability. The consumers and publishers will find this extension also interesting as they can now enlarge the amount of indexable content, and beyond that they can index not only information and meta-data but also the data itself.
Feel free to provide your feedback, suggestions and comments, to improve the proposal.
Regards
Marc Twagirumukiza, Agfa HealthCare N.V.
Belgium.