Set schema:logo and schema:photo as subproperties of schema:image #114 #115
Conversation
This comment has been minimized.
This comment has been minimized.
|
I was surprised to see "A sub property of image" added to the rdfs:comment but this is common practice in the schema, see for example http://schema.org/buyer, so this looks good. |
|
I had the same reaction as @scor to the "A sub property of image" sentences, having never liked them much in the actions vocab either. But you're right we do use the phrase elsewhere. However now that the site has built-in navigation structures for sub-properties, my preference would be to simplify the wording of the Action-related subproperties and to avoid adding that phrase here. Does this make sense? ps. thanks for the pull req :) |
danbri
added a commit
that referenced
this pull request
Sep 10, 2014
Set schema:logo and schema:photo as subproperties of schema:image #114
|
(I'll back out the comment changes manually.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Issue : #114