New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sdo v3rollbackfixup #1215

Merged
merged 15 commits into from Jun 21, 2016

Conversation

Projects
None yet
1 participant
@danbri
Contributor

danbri commented Jun 17, 2016

This fixes all problems identified in #1203 and covers much of what we need to get a new release out.

To summarise, the version 3.0 release included some unintended rollback of prior changes. I have gone through the situation triple-by-triple and assembled this package of fixes.

See also #1212 for release planning.

@RichardWallis and @twamarc have helped with this, but additional reviews would be welcome.

/cc Steering Group, @shankarnat @tmarshbing @chaals @pmika @scor @mfhepp @vholland @rvguha .

danbri added some commits Jun 17, 2016

Fixed hyperlinks in prepTime, cookTime (using Markdown).
The 3.0 release had this reverted, removing HTML entity escape markup. See #1203

Also minor whitespace fixes in RDFa.
Fixed reversion: videoFormat is again expected on BroadcastEvent and …
…ScreeningEvent (and BroadcastService), rather than TelevisionStation.

The 3.0 release had this reverted, See #1203

See also http://schema.org/docs/releases.html#g577
Commented out section deleted. See #1073.
Also #1203 as this was (falsely) suspected to be an accidental reversion.
Fixed hyperlink cookTime (using Markdown).
The 3.0 release had this reverted, removing HTML entity escape markup. See #1203

Note that 00d83e1 had a typo. It fixed totalTime not cookTime.
Fixed reversions to netWorth definition.
We choose not to mention organizations at this stage. FIBO and other
considerations could mean we revisit this, but this commit fixes an
accidental reversion that prematurely reintroduced idea that netWorth
applied to Organization. If/when we do that, we need to change domainIncludes also.

The 3.0 release had this reverted. See #1203

See also http://schema.org/docs/releases.html#g585 #585
@danbri

This comment has been minimized.

Show comment
Hide comment
@danbri

danbri Jun 17, 2016

Contributor

FYI all tests pass.

I am pushing this material to webschema.org and sdo-makemake.appspot.com to assist reviewing.

Contributor

danbri commented Jun 17, 2016

FYI all tests pass.

I am pushing this material to webschema.org and sdo-makemake.appspot.com to assist reviewing.

danbri added some commits Jun 21, 2016

Added: schema:paymentStatus schema:rangeIncludes schema:PaymentStatus…
…Type

See also #1203 #518
This restores accidental rollback between v2.2 and v3.0.

This change was missed during first phase of repair, but caught due to
issue-by-issue checking of releases.html.

@danbri danbri merged commit 9cc8933 into sdo-makemake Jun 21, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment