-
Notifications
You must be signed in to change notification settings - Fork 825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sdo v3rollbackfixup #1215
Merged
Merged
Sdo v3rollbackfixup #1215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ical terms to health-lifesci. See #1203 Terms are: * http://schema.org/breastfeedingWarning * http://schema.org/healthCondition * http://schema.org/prescriptionStatus * http://schema.org/secondaryPrevention
The 3.0 release had this reverted (to Article). See #1203 See also http://schema.org/docs/releases.html#g526
The 3.0 release had this reverted. See #1203 See also http://schema.org/docs/releases.html#g346
The 3.0 release had this reverted. See #1203 See also http://schema.org/docs/releases.html#g596
The 3.0 release had this reverted, removing HTML entity escape markup. See #1203 Also minor whitespace fixes in RDFa.
The 3.0 release had this reverted, See #1203 #1198 See also http://schema.org/docs/releases.html#g611
…ScreeningEvent (and BroadcastService), rather than TelevisionStation. The 3.0 release had this reverted, See #1203 See also http://schema.org/docs/releases.html#g577
…inverseOf each other. The 3.0 release had this reverted, See #1203 See also http://schema.org/docs/releases.html#g535
Also #1203 as this was (falsely) suspected to be an accidental reversion.
…tions. The 3.0 release had this reverted. See #1203 See also http://schema.org/docs/releases.html#g343 #343
We choose not to mention organizations at this stage. FIBO and other considerations could mean we revisit this, but this commit fixes an accidental reversion that prematurely reintroduced idea that netWorth applied to Organization. If/when we do that, we need to change domainIncludes also. The 3.0 release had this reverted. See #1203 See also http://schema.org/docs/releases.html#g585 #585
FYI all tests pass. I am pushing this material to webschema.org and sdo-makemake.appspot.com to assist reviewing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes all problems identified in #1203 and covers much of what we need to get a new release out.
To summarise, the version 3.0 release included some unintended rollback of prior changes. I have gone through the situation triple-by-triple and assembled this package of fixes.
See also #1212 for release planning.
@RichardWallis and @twamarc have helped with this, but additional reviews would be welcome.
/cc Steering Group, @shankarnat @tmarshbing @chaals @pmika @scor @mfhepp @vholland @rvguha .